Improve .obj serialization times - fixes #1407 #1408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZephyrRaine
changed the title
hrgdavor
approved these changes
Nov 20, 2025
Contributor
hrgdavor
left a comment
hrgdavor
left a comment
There was a problem hiding this comment.
nice performance improvement
z3dev
approved these changes
Nov 22, 2025
Member
There was a problem hiding this comment.
@ZephyrRaine These changes look fine. It would be nice to get some statistics on the performance improvement.
By the way, V2 changes are released periodically so these changes will probably be released in January. Is that ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Description:
Replaced
verticesarray with a Map in order to check existence with simple O(1) lookup instead of O(n)indexOf. Greatly reduces export times and no diff detected on .obj outputs. This fixes #1407 where more details can be found.Tests:
All tests passed, except one for web that already wasn't passing after a fresh clone.