Skip to content

Improve .obj serialization times - fixes #1407 #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
z3dev merged 1 commit into from
Nov 22, 2025
Merged

Improve .obj serialization times - fixes #1407 #1408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/io/obj-serializer/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ const serialize = (options, ...objects) => {
// construct the contents of the OBJ file
let body = '# Wavefront OBJ file generated by JSCAD\n'

// find unique vertices
const vertices = []
// find unique vertices - use Map for O(1) lookup instead of O(n) indexOf
const vertexMap = new Map() // vertex string -> index (1-based)

// convert objects
// TODO: group objects together
Expand All @@ -86,9 +86,10 @@ const serialize = (options, ...objects) => {
polygons.forEach((polygon) => {
polygon.vertices.forEach((vertex) => {
const vertexString = convertVertex(vertex)
if (vertices.indexOf(vertexString) < 0) {
if (!vertexMap.has(vertexString)) {
// add unique vertices
vertices.push(vertexString)
const index = vertexMap.size + 1 // OBJ uses 1-based indexing
vertexMap.set(vertexString, index)
body += `${vertexString}\n`
}
})
Expand All @@ -99,7 +100,7 @@ const serialize = (options, ...objects) => {
polygons.forEach((polygon) => {
// convert vertices to indices
const indices = polygon.vertices
.map((v) => vertices.indexOf(convertVertex(v)) + 1)
.map((v) => vertexMap.get(convertVertex(v)))
// set face color
const color = getColorName(polygon) || objectColor || 'default'
if (color !== previousColor) {
Expand Down