improvements on dialogflow and google chat #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
k-okada
commented
Apr 10, 2023
k-okada
commented
…rver fails, set df_result == None as initial value
tkmtnt7000
reviewed
Apr 12, 2023
google_chat_ros/scripts/helper.py
Outdated
| # Get configuration params | ||
| self.to_dialogflow_task_executive = rospy.get_param("~to_dialogflow_client") | ||
| self.sound_play_jp = rospy.get_param("~debug_sound") | ||
| self.send_dialogflow_resonse_to_google_chat = rospy.get_param("~send_dialogflow_resonse_to_google_chat", True) |
Member
There was a problem hiding this comment.
Suggested change
| self.send_dialogflow_resonse_to_google_chat = rospy.get_param("~send_dialogflow_resonse_to_google_chat", True) | |
| self.send_dialogflow_response_to_google_chat = rospy.get_param("~send_dialogflow_response_to_google_chat", True) |
k-okada
changed the title
…ogle_chat param. Set False did not returns dialogflow response to chat
k-okada
force-pushed
the
add_more_functions
branch
from
32c0ddb to
46525ef
Compare
Member
Author
|
we may do not need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.