Skip to content

Conversation

@Michi-Tsubaki
Copy link
Contributor

This PR add ROS package image_restoration for image denoising package. This is useful when you have to use low quality image like 600x400 image. In my current work, image from nextage default camera is low. So I've tried to make this package.

This package is using catkin_virtualenv like sound_classification. Because of that, I cannot put this in jsk_perception(not depend on catkin_virtualenv).

The impact of this package is ..., just look at the pictures below.

Before restoration ( noisy )

After restoration ( denoised )

Notice: When using GPU, you can get 1 image /sec . When using CPU, you can get 1 image / 7sec .

@Michi-Tsubaki
Copy link
Contributor Author

For more detail check README.md

Copy link
Member

@mqcmd196 mqcmd196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature!

@mqcmd196
Copy link
Member

mqcmd196 commented May 2, 2025

I'm sorry,

PYTHON_INTERPRETER python3 .

Please read the official document

@Michi-Tsubaki Michi-Tsubaki force-pushed the add-image-restoration branch from c95ea68 to b30465a Compare May 8, 2025 06:34
@Michi-Tsubaki
Copy link
Contributor Author

@mqcmd196 -san
I added test(launch) and fix CMakeList(install and test).
Now, only two tests have failed, and these are for indigo and melodic.
Screenshot from 2025-05-19 16-39-53

@mqcmd196
Copy link
Member

@Michi-Tsubaki

Now, only two tests have failed, and these are for indigo and melodic.

Good! Skip old distro like https://github.com/jsk-ros-pkg/jsk_3rdparty/blob/48c605596a8b39c913c2d49c4869476f3422a524/emotion_analyzer/CMakeLists.txt#L27-L33

@mqcmd196
Copy link
Member

mqcmd196 commented May 19, 2025

And could you rebase or pull current origin/master and squash current commits into a few commits?

@Michi-Tsubaki
Copy link
Contributor Author

@mqcmd196 I merged origin/master, and then squash commits git rebase -i <commit>~n. However, it seems wrong. I seems like add new long commits to the branch. Could you give me some advice to fix?
All the test was passed when ba33158,
but I had to try re-running many time because jsk_travis time-out or fall several time. Now it fails. I try to re-run after I fix all the bugs.

@Michi-Tsubaki Michi-Tsubaki force-pushed the add-image-restoration branch 3 times, most recently from 7f610f5 to 5f31490 Compare May 20, 2025 08:18
@Michi-Tsubaki
Copy link
Contributor Author

@mqcmd196 I merged origin/master, and then squash commits git rebase -i <commit>~n. However, it seems wrong. I seems like add new long commits to the branch. Could you give me some advice to fix? All the test was passed when ba33158, but I had to try re-running many time because jsk_travis time-out or fall several time. Now it fails. I try to re-run after I fix all the bugs.

Fixed and done. Now waiting for CI to pass.

@mqcmd196
Copy link
Member

@Michi-Tsubaki Nice! Could you delete, e522bc9, 8a3c12a, ee504ff ?

@Michi-Tsubaki Michi-Tsubaki force-pushed the add-image-restoration branch from 5f31490 to 7250901 Compare May 20, 2025 08:24
@Michi-Tsubaki
Copy link
Contributor Author

@Michi-Tsubaki Nice! Could you delete, e522bc9, 8a3c12a, ee504ff ?

done!

@Michi-Tsubaki
Copy link
Contributor Author

Michi-Tsubaki commented May 20, 2025

@mqcmd196

  • rebase origin/master
  • squash commits into a few commits
  • all the workflows pass (skip old distro)
  • delete three commits
    All these four tasks completed.

@mqcmd196
Copy link
Member

Superb! Thank you for your fix!!

Please check Michi-Tsubaki#1 and merge it if there is no problem. It is required to release

Copy link
Member

@mqcmd196 mqcmd196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants