Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop/fetch][gazebo] Gazebo for noetic #1913

Open
wants to merge 4 commits into
base: develop/fetch
Choose a base branch
from

Conversation

mqcmd196
Copy link
Member

  • Build support for gazebo in noetic
  • Add launch arg to turn off the google_analyze_text, cpu_monitor

@mqcmd196
Copy link
Member Author

mqcmd196 commented May 20, 2024

TODO:

  • Enable move_base
  • Check 73B2 environment
  • Check on the real robot whether it doesn't break the function for real robot

@mqcmd196
Copy link
Member Author

@yoshiki-447 Try this

Copy link
Contributor

@pazeshun pazeshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoshiki-447
Copy link

yoshiki-447 commented May 20, 2024

When I executed the following:

roslaunch fetch_gazebo simulation.launch
roslaunch fetch_moveit_config move_group.launch

rlwrap roseus
(load "package://fetcheus/fetch-interface.l")
(fetch-init)

I faced the following warning periodically on rlwrap roseus:

Warning: TF_REPEATED_DATA ignoring data with redundant timestamp for frame base_link (parent odom) at time 720.438000 according to authority unknown_publisher
         at line 278 in /tmp/binarydeb/ros-noetic-tf2-0.7.7/src/buffer_core.cpp

cc @pazeshun

@yoshiki-447
Copy link

yoshiki-447 commented May 20, 2024

To remove this warning, ZebraDevs/robot_controllers#83 is required.

cc @pazeshun

@mqcmd196
Copy link
Member Author

BTW, I can't see any TF_REPEATED_DATA warning in my euslisp console with current jsk_fetch_user.noetic.repos . When does the warning spawn?

@pazeshun
Copy link
Contributor

pazeshun commented May 21, 2024

If you use a high-performance PC, you may not see warnings.
Could you also check in a relatively low-performance PC?

A warning appears when gazebo publishes tf from odom to base_link whose timestamp is the same as tf published previously.
I think this is because ros::Time::now()
https://github.com/ZebraDevs/robot_controllers/blob/938b67673a31d0a495d016e4a31c75263258092f/robot_controllers/src/diff_drive_base.cpp#L375
inside the callback publishing tf at 100Hz
https://github.com/ZebraDevs/robot_controllers/blob/938b67673a31d0a495d016e4a31c75263258092f/robot_controllers/src/diff_drive_base.cpp#L130-L132
sometimes returns the same timestamp as the previous callback.

I assume this problem occurs in relatively low-performance PC where gazebo is slow and ROS Clock may not be updated well.
We use ThinkPad P16s Gen2.
cf. http://wiki.ros.org/roscpp/Overview/Timers#Wall-clock_Timers

@mqcmd196
Copy link
Member Author

mqcmd196 commented May 21, 2024 via email

@mqcmd196 mqcmd196 marked this pull request as ready for review May 21, 2024 03:30
@mqcmd196 mqcmd196 force-pushed the PR/develop/fetch/gazebo-noetic branch from afdb651 to bc6359c Compare May 21, 2024 05:44
@mqcmd196
Copy link
Member Author

I confirmed the TF_REPEATED_DATA spawns on the console. Please unset ZebraDevs/robot_controllers#83 as draft.

@mqcmd196 mqcmd196 requested review from sktometometo and pazeshun May 22, 2024 03:54
@sktometometo
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants