Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add roseus_bt package #681

Draft
wants to merge 164 commits into
base: master
Choose a base branch
from
Draft

Add roseus_bt package #681

wants to merge 164 commits into from

Conversation

Affonso-Gui
Copy link
Member

Adding the roseus_bt package to run Behavior Trees in roseus.

Probably not perfect but have included a lot of examples so hoping that it should be fairly easy to follow!

knorth55
knorth55 requested changes Aug 13, 2021
View reviewed changes
roseus_bt/README.md Outdated Show resolved Hide resolved
roseus_bt/CMakeLists.txt Outdated Show resolved Hide resolved
roseus_bt/sample/README.md Outdated Show resolved Hide resolved
@Affonso-Gui Affonso-Gui changed the title Add roseus_bt package [WIP] Add roseus_bt package Aug 19, 2021
@Affonso-Gui Affonso-Gui mentioned this pull request Jan 7, 2022
Merged
@708yamaguchi
Copy link
Member

When I run

roseus t04_subscriber-action-server.l
rosrun roseus_bt_tutorials t04_subscriber

The latter command outputs an error.

terminate called after throwing an instance of 'BT::RuntimeError'
  what():  Error at line 13: -> Node not recognized: RetryUntilSuccesful
Aborted (core dumped)

@Affonso-Gui
Copy link
Member Author

@708yamaguchi That name was a typo that was fixed on BehaviorTree/BehaviorTree.CPP@f54f6d8 (in the latest version)

I've just corrected it

@708yamaguchi
Copy link
Member

Thank you so much.
It works well!

@knorth55 knorth55 mentioned this pull request Jul 6, 2022
Open
3 tasks
@knorth55
Copy link
Member

knorth55 commented Sep 12, 2022 •
edited
Loading

.travis is changed in this PR.
2c772ca (#681)

do not change .travis.

@knorth55 knorth55 mentioned this pull request Sep 12, 2022
Open
4 tasks
@knorth55
Copy link
Member

knorth55 commented Feb 6, 2023 •
edited
Loading

this branch is old that we cannot build groot eus10 correctly.
please update this branch @Affonso-Gui
i.e. cancelAction() API in ws_action_client.h has changed.

@Affonso-Gui
Copy link
Member Author

@knorth55 Thanks, I will take a look next week.

@Affonso-Gui Affonso-Gui marked this pull request as draft February 14, 2023 01:24
Affonso-Gui and others added 15 commits February 14, 2023 10:38
@Affonso-Gui
(roseus_bt) Better euslisip function formatting with underscores
bf49aa1
@Affonso-Gui
(roseus_bt) Avoid CMake errors on bloom release
90f3074
@Affonso-Gui
(roseus_bt) define result_ member as Document to avoid having the all…
c2da0cc 
…ocator go out of scope
@Affonso-Gui
(roseus_bt) Throw errors on failed requests
a27c275
@Affonso-Gui
(roseus_bt) Throw errors on failed remote service calls
3ba0a24
@Affonso-Gui
(roseus_bt) Throttle actions/status topic for performance
60680a6
@Affonso-Gui
(roseus_bt) Timeout cancel and check result in remote actions
f56ce1b
@knorth55 @Affonso-Gui
remove ros args in parse_command_line
1134d32
@knorth55 @Affonso-Gui
add common_argument_mapping.h
b4b52b8
@knorth55 @Affonso-Gui
add rosparam_argument_mapping.h
4fb75ed
@Affonso-Gui
(roseus_bt) Remove unused imports and minor style changes in argument…
914eedf 
… mapping
@Affonso-Gui
(roseus_bt) Add optional timeout parameter to the action template
75eaf4e
@Affonso-Gui
(roseus_bt) Use ros::package::getPath when loading model file
dbb2453
@Affonso-Gui
(roseus_bt) Set timeout as an argument in cancelGoal()
53b82f0
@Affonso-Gui
(roseus_bt) Use SubTreePlus instead of SubTree
26865cc
@Affonso-Gui
Copy link
Member Author

Affonso-Gui commented Feb 14, 2023 •
edited
Loading

@knorth55
I have updated the branch and confirmed that it compiles with groot roseus_bt and behaviortree_cpp_v3 v3.8.

However, I plan on prioritizing the eus10 branch and PR (#718) from now on, which I will also be reviewing soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knorth55 knorth55 knorth55 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Affonso-Gui @708yamaguchi @knorth55