Skip to content

build prerelease jupyterhub #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

build prerelease jupyterhub #7

merged 2 commits into from
Apr 10, 2025

Conversation

minrk
Copy link
Member

@minrk minrk commented Apr 7, 2025

adding a prerelease version constraint to requirements.in makes prerelease versions accepted

what happens to tags when the version is a prerelease?

@manics
Copy link
Member

manics commented Apr 8, 2025

I think this has identified a couple issues in the GH workflow:

@manics
Copy link
Member

manics commented Apr 9, 2025

Can you add prereleaseHasBuild: "true" to all the jupyterhub/action-major-minor-tag-calculator@v3 steps?
manics@2ff70f4

@minrk
Copy link
Member Author

minrk commented Apr 10, 2025

I added the flag and added the credentials for quay and dockerhub. If we merge this, will 5.3.0rc0 be published?

@manics
Copy link
Member

manics commented Apr 10, 2025

Yes, it should

@minrk
Copy link
Member Author

minrk commented Apr 10, 2025

ok, are we ready to land it, then?

@manics manics merged commit bdcdd21 into jupyterhub:main Apr 10, 2025
3 checks passed
@manics
Copy link
Member

manics commented Apr 10, 2025

Failed 😢
https://github.com/jupyterhub/jupyterhub-container-images/actions/runs/14378904626/job/40317797819

Run jupyterhub/[email protected]
  with:
    repository: jupyterhub/jupyterhub
    version: 5.3.0rc0
    allTags: false
    strict: true
  env:
    LATEST_BRANCH: main
    PUBLISH_BRANCH: main
    IMAGE: jupyterhub/jupyterhub
    SINGLEUSER: jupyterhub/singleuser
    PUBLISH_DOCKERIO: true
    CACHE_FROM: type=gha
    CACHE_TO: type=gha,mode=max
Error: Invalid version, must be MAJOR.MINOR.PATCH: 5.3.0rc0

I can't think of any obvious reason for the failure since the PR CI runs were fine

@manics
Copy link
Member

manics commented Apr 10, 2025

https://github.com/jupyterhub/action-get-quayio-tags/blob/v0.1.0/src/quayio.js#L57-L65
strict is true here:


but I'm still confused by why it was fine in the PR runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants