fix: Ensure a list bind_dn_template is properly validated
#289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like we are ignoring the value of `bind_dn_template` when it is a string in validator. This PR fixes it by checking if value is of list instance and setting up the value.
manics
reviewed
Oct 29, 2024
| @@ -150,6 +150,8 @@ def _validate_bind_dn_template(self, proposal): | |||
| rv = [] | |||
| if isinstance(proposal.value, str): | |||
| rv = [proposal.value] | |||
| elif isinstance(proposal.value, list): | |||
There was a problem hiding this comment.
I think this should either be an unconditional else, or there should be a separate else clause that raises a TraitError.
There was a problem hiding this comment.
Yes, makes sense. I think if the value is neither str nor list, traitlets should raise an error anyways, right?! I mean we do not need to raise it manually I imagine. If so, I will change it to unconditional else.
There was a problem hiding this comment.
The allowed types are enforced by traitlets, list and strings are allowed
consideRatio
approved these changes
Oct 29, 2024
manics
approved these changes
Oct 29, 2024
This was referenced Oct 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like we are ignoring the value of
bind_dn_templatewhen it is a string in validator. This PR fixes it by checking if value is of list instance and setting up the value correctly.