Skip to content

Write .model.Version to SDMX-ML #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 21, 2024
Merged

Write .model.Version to SDMX-ML #198

merged 11 commits into from
Oct 21, 2024

Conversation

@khaeru
Copy link
Owner

@khaeru khaeru commented Oct 18, 2024 •
edited
Loading

PR checklist

  • Checks all ✅
  • Update documentation
  • Update doc/whatsnew.rst

@khaeru khaeru added bug writer Convert objects to other formats xml SDMX-ML format labels Oct 18, 2024
@khaeru khaeru self-assigned this Oct 18, 2024
@codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.91%. Comparing base (9186c89) to head (64fd68f).
Report is 128 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   98.87%   97.91%   -0.97%     
==========================================
  Files          97       97              
  Lines        7841     7854      +13     
==========================================
- Hits         7753     7690      -63     
- Misses         88      164      +76
Files with missing lines Coverage Δ
sdmx/message.py 100.00% <ø> (ø)
sdmx/model/common.py 99.90% <100.00%> (-0.01%) ⬇️
sdmx/model/version.py 100.00% <ø> (ø)
sdmx/tests/model/test_common.py 100.00% <100.00%> (ø)
sdmx/tests/test_model.py 100.00% <ø> (ø)
sdmx/tests/writer/test_writer_xml.py 100.00% <100.00%> (ø)
sdmx/urn.py 100.00% <100.00%> (ø)
sdmx/writer/xml.py 98.06% <100.00%> (ø)

... and 18 files with indirect coverage changes

khaeru added a commit that referenced this pull request Oct 18, 2024
@khaeru
Add #198 to doc/whatsnew
183b24a
@khaeru khaeru force-pushed the fix/write-xml-version branch from 183b24a to b6c358f Compare October 19, 2024 08:39
khaeru added 2 commits October 21, 2024 19:49
@khaeru
Improve .urn
a00b9b9 
- Supply default None for most URN attributes.
- Defer imports; allows to import URN in .model.
@khaeru
Improve URN handling in .model.common
0ae68be 
- Import URN at the module level.
- Remove IdentifableArtefact.urn_group dataclass field.
- Simplify and align handling of URN info in
  {Identifiable,Versionable,Maintainable}Artefact.
@khaeru khaeru force-pushed the fix/write-xml-version branch from eea992d to 582d466 Compare October 21, 2024 18:04
@khaeru khaeru force-pushed the fix/write-xml-version branch from 582d466 to 64fd68f Compare October 21, 2024 18:23
@khaeru khaeru merged commit e88f8d3 into main Oct 21, 2024
20 checks passed
@khaeru khaeru deleted the fix/write-xml-version branch October 21, 2024 18:27
@khaeru khaeru mentioned this pull request Oct 23, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@khaeru khaeru

Labels

bug writer Convert objects to other formats xml SDMX-ML format

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khaeru