Remove misleading comment #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment falsely indicates that malformed IRC messages would
be null.
However, since the switch to a proper parser the function always
returns an IrcMessage object, no matter how broken the input is.
```
const parser = require('./src/irclineparser');
console.log(parser('\0'));
// IrcMessage {
// tags: [Object: null prototype] {},
// prefix: '',
// nick: '',
// ident: '',
// hostname: '',
// command: '\x00',
// params: []
// }
```
Hence, remove the comment to avoid misleading readers
but keep the guard, should the parser change in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment falsely indicates that malformed IRC messages would be null.
However, since the switch to a proper parser the function always returns an IrcMessage object, no matter how broken the input is.
Hence, remove the comment to avoid misleading readers but keep the guard, should the parser change in the future.