Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misleading comment #370

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Commits on Dec 27, 2023

  1. Remove misleading comment

    The comment falsely indicates that malformed IRC messages would
    be null.
    
    However, since the switch to a proper parser the function always
    returns an IrcMessage object, no matter how broken the input is.
    
    ```
    const parser = require('./src/irclineparser');
    console.log(parser('\0'));
    
    // IrcMessage {
    //   tags: [Object: null prototype] {},
    //   prefix: '',
    //   nick: '',
    //   ident: '',
    //   hostname: '',
    //   command: '\x00',
    //   params: []
    // }
    ```
    
    Hence, remove the comment to avoid misleading readers
    but keep the guard, should the parser change in the future.
    brunnre8 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    e1e0f87 View commit details
    Browse the repository at this point in the history