Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

fix 404 in API comment for HTML ref doc build #480

Merged
merged 1 commit into from
Jul 8, 2019
Merged

fix 404 in API comment for HTML ref doc build #480

merged 1 commit into from
Jul 8, 2019

Conversation

RichieEscarez
Copy link
Contributor

Fixes knative/docs#1559

Proposed Changes

  • add whitespace between URL and parenthesis to workaround known blackfriday markdown processor limitation. otherwise, this file gets generated with a 404 broken link in the HTML (for the API ref docs in knative.dev)

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 3, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2019
n3wscott
n3wscott approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2019
@knative-prow-robot knative-prow-robot merged commit 8a3c48d into knative:master Jul 8, 2019
@RichieEscarez RichieEscarez mentioned this pull request Jul 8, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@n3wscott n3wscott n3wscott approved these changes

@grantr grantr Awaiting requested review from grantr

@Harwayne Harwayne Awaiting requested review from Harwayne

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gen-api-reference-docs API docs build script limitations
4 participants
@RichieEscarez @knative-prow-robot @n3wscott @googlebot