Depracate array_layout in favor of layout_type #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janciesko
force-pushed
the
depr-array-layout
branch
2 times, most recently
from
3d33249 to
babf89e
Compare
Signed-off-by: Jan Ciesko <jan.ciesko@gmail.com>
janciesko
force-pushed
the
depr-array-layout
branch
from
babf89e to
6b1faaf
Compare
cwpearson
requested changes
Oct 17, 2025
|
|
||
| .. cpp:type:: array_layout | ||
|
|
||
| The layout of the ``DynRankView``. (Deprecated since Kokkos 5.0) |
Contributor
There was a problem hiding this comment.
Suggested change
| The layout of the ``DynRankView``. (Deprecated since Kokkos 5.0) | |
| The layout of the ``DynRankView``. (Deprecated since Kokkos 5.0: use ``layout_type``) |
|
|
||
| .. cpp:type:: array_layout | ||
|
|
||
| A tag signifying that this models the Layout concept. (Deprecated since Kokkos 5.0) |
Contributor
There was a problem hiding this comment.
Suggested change
| A tag signifying that this models the Layout concept. (Deprecated since Kokkos 5.0) | |
| A tag signifying that this models the Layout concept. (Deprecated since Kokkos 5.0: use ``layout_type``) |
|
|
||
| .. cpp:type:: array_layout | ||
|
|
||
| A tag signifying that this models the Layout concept. (Deprecated since Kokkos 5.0) |
Contributor
There was a problem hiding this comment.
Suggested change
| A tag signifying that this models the Layout concept. (Deprecated since Kokkos 5.0) | |
| A tag signifying that this models the Layout concept. (Deprecated since Kokkos 5.0: use ``layout_type``) |
| .. cpp:type:: array_layout | ||
|
|
||
| A tag signifying that this models the Layout concept | ||
| A tag signifying that this models the Layout concept. (Deprecated since Kokkos 5.0) |
Contributor
There was a problem hiding this comment.
Suggested change
| A tag signifying that this models the Layout concept. (Deprecated since Kokkos 5.0) | |
| A tag signifying that this models the Layout concept. (Deprecated since Kokkos 5.0: use ``layout_type``) |
| ^^^^^^^^^^^ | ||
|
|
||
| .. cpp:type:: array_layout | ||
| .. deprecated:: 5.0 |
Contributor
There was a problem hiding this comment.
Suggested change
| .. deprecated:: 5.0 | |
| .. deprecated:: 5.0 | |
| Use ``layout_type``. |
| typedef ... scratch_memory_space; | ||
| typedef ... array_layout; | ||
| typedef ... layout_type; | ||
| typedef ... array_layout; // Deprecated since Kokkos 5.0 |
Contributor
There was a problem hiding this comment.
Suggested change
| typedef ... array_layout; // Deprecated since Kokkos 5.0 | |
| typedef ... array_layout; // Deprecated since Kokkos 5.0, use layout_type |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.