-
Notifications
You must be signed in to change notification settings - Fork 61
Depracate array_layout in favor of layout_type #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -236,7 +236,9 @@ Additionally, the following type aliases (a.k.a. ``typedef`` s) will be defined | |||||
|
|
||||||
| * ``Ex::memory_space``: the default |MemorySpace|_ to use when executing with ``Ex``. Kokkos guarantees that ``Kokkos::SpaceAccessibility<Ex, Ex::memory_space>::accessible`` will be ``true`` (see |KokkosSpaceAccessibility|_) | ||||||
|
|
||||||
| * ``Ex::array_layout``: the default ``ArrayLayout`` recommended for use with ``View`` types accessed from ``Ex``. | ||||||
| * ``Ex::array_layout``: the default ``ArrayLayout`` recommended for use with ``View`` types accessed from ``Ex``. //Deprecated since Kokkos 5.0 | ||||||
|
|
||||||
| * ``Ex::layout_type``: the default ``LayoutType`` recommended for use with ``View`` types accessed from ``Ex``. | ||||||
|
|
||||||
| * ``Ex::scratch_memory_space``: the ``ScratchMemorySpace`` that parallel patterns will use for allocation of scratch memory (for instance, as requested by a |KokkosTeamPolicy|_). Only unmanaged Views can be created using this memory space. | ||||||
|
|
||||||
|
|
@@ -268,7 +270,8 @@ Synopsis | |||||
| typedef ... memory_space; | ||||||
| typedef Device<execution_space, memory_space> device_type; | ||||||
| typedef ... scratch_memory_space; | ||||||
| typedef ... array_layout; | ||||||
| typedef ... layout_type; | ||||||
| typedef ... array_layout; // Deprecated since Kokkos 5.0 | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| typedef ... size_type; | ||||||
|
|
||||||
| ExecutionSpaceConcept(); | ||||||
|
|
@@ -305,7 +308,7 @@ Typedefs | |||||
|
|
||||||
| * ``device_type``: ``DeviceType<execution_space,memory_space>``. | ||||||
|
|
||||||
| * ``array_layout``: The default ``ArrayLayout`` recommended for use with ``View`` types accessed from |ExecutionSpaceConcept|_. | ||||||
| * ``layout_type``: The default ``LayoutType`` recommended for use with ``View`` types accessed from |ExecutionSpaceConcept|_. | ||||||
|
|
||||||
| * ``scratch_memory_space``: The ``ScratchMemorySpace`` that parallel patterns will use for allocation of scratch memory (for instance, as requested by a |KokkosTeamPolicy|_). Only unmanaged Views can be created using this memory space. | ||||||
|
|
||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -25,6 +25,10 @@ Description | |||||
|
|
||||||
| .. cpp:type:: array_layout | ||||||
|
|
||||||
| A tag signifying that this models the Layout concept. (Deprecated since Kokkos 5.0) | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| .. cpp:type:: layout_type | ||||||
|
|
||||||
| A tag signifying that this models the Layout concept. | ||||||
|
|
||||||
| .. rubric:: Member Variables | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -25,6 +25,10 @@ Description | |||||
|
|
||||||
| .. cpp:type:: array_layout | ||||||
|
|
||||||
| A tag signifying that this models the Layout concept. (Deprecated since Kokkos 5.0) | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| .. cpp:type:: layout_type | ||||||
|
|
||||||
| A tag signifying that this models the Layout concept. | ||||||
|
|
||||||
| .. rubric:: Member Variables | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -41,7 +41,11 @@ Description | |||||
|
|
||||||
| .. cpp:type:: array_layout | ||||||
|
|
||||||
| A tag signifying that this models the Layout concept | ||||||
| A tag signifying that this models the Layout concept. (Deprecated since Kokkos 5.0) | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| .. cpp:type:: layout_type | ||||||
|
|
||||||
| A tag signifying that this models the Layout concept. | ||||||
|
|
||||||
| .. rubric:: Constructors | ||||||
|
|
||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.