Two-stage GS: initialize functor bool members #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Kelley <[email protected]>
lucbv
approved these changes
Nov 6, 2024
|
Same thing for me, this does not happen in my local build. |
|
Sweet, ubuntu-asan-ubsan-ci is clean now. |
|
Down the line we may want to run these sanitizers on more configurations like complex numbers for instance, maybe also with clang in case that changes something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #2415 and #2417 - fix one more UBsan error. This one happened in the CI build, but not my local build.
It's the same kind of error we fixed before, where bool members of a struct were left uninitialized.