Fix & enable HW rotation on notched devices on P+

[NiLuJe]

Looks simple enough (he said, hopefully ;p) :).

---

This change is 

[NiLuJe]

Ah. Knew it was too easy: this excluded the status bar area, too.

[pazos]

As you know getScreenSizeWithConstraints(activity) only works on pre KitKat devices (apis 17 & 18) and it is completely deprecated in immersive mode (apis19+).

Since legacy APIs doesn't use HW rotation I think it is safe to ignore getScreenAvailableWidth et al.

[NiLuJe]

Note to self: nav bar, not status bar.

[NiLuJe]

As you know getScreenSizeWithConstraints(activity) only works on pre KitKat devices (apis 17 & 18) and it is completely deprecated in immersive mode (apis19+).

Since legacy APIs doesn't use HW rotation I think it is safe to ignore getScreenAvailableWidth et al.

Err, the only thing it does is using getMetrics instead of getRealMetrics. AFAICT, that's very much not deprecated until SDK 30, and it indeed worked perfectly fine on my API 29 phone. It just happens to also exclude the nav bar, which is a problem ^^.

Speaking of, the SDK 30 variant has a code excerpt to do that manually, and it appears to be able to tell display cutouts apart from the nav bar ;).

[pazos]

@NiLuJe: You're right. I was talking about our usage :P. As we always enable immersive mode in KitKat+ devices, we don't need getMetrics there. It could be relevant for #238, but there're better ways to retrieve screen size on each surface change

But having that available doesn't hurt either. 👍