-
Notifications
You must be signed in to change notification settings - Fork 331
Bump Ktor version to 3.2.1 and add release details #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
## Walkthrough
This update increases the Ktor framework and plugin version from 3.2.0 to 3.2.1 across multiple Gradle, Maven, and configuration files. It also updates documentation to reflect the new release, removes a duplicate H2 dependency in one build script, and adjusts a test case to change the parameters of a mocked `UserInfo` object.
## Changes
| Files/Paths | Change Summary |
|-----------------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------|
| codeSnippets/gradle.properties<br>codeSnippets/snippets/tutorial-client-kmm/gradle/libs.versions.toml<br>codeSnippets/snippets/tutorial-server-db-integration/gradle/libs.versions.toml<br>codeSnippets/snippets/tutorial-server-get-started-maven/pom.xml<br>help-versions.json<br>project.ihp<br>v.list<br>codeSnippets/snippets/migrating-express-ktor/gradle.properties | Updated Ktor version references from 3.2.0 to 3.2.1 in configuration and version catalog files; also updated Kotlin and Logback versions in migrating-express-ktor gradle.properties |
| codeSnippets/snippets/aws-elastic-beanstalk/build.gradle.kts<br>codeSnippets/snippets/deployment-ktor-plugin/build.gradle.kts<br>codeSnippets/snippets/engine-main-custom-environment/build.gradle.kts<br>codeSnippets/snippets/forwarded-header/build.gradle.kts<br>codeSnippets/snippets/htmx-integration/build.gradle.kts<br>codeSnippets/snippets/legacy-interactive-website/build.gradle.kts<br>codeSnippets/snippets/proguard/build.gradle.kts<br>codeSnippets/snippets/server-websockets-sharedflow/build.gradle.kts<br>codeSnippets/snippets/tutorial-server-get-started/build.gradle.kts<br>codeSnippets/snippets/tutorial-server-restful-api/build.gradle.kts<br>codeSnippets/snippets/tutorial-server-routing-and-requests/build.gradle.kts<br>codeSnippets/snippets/tutorial-server-web-application/build.gradle.kts<br>codeSnippets/snippets/tutorial-server-websockets/build.gradle.kts<br>codeSnippets/snippets/tutorial-website-static/build.gradle.kts | Updated `io.ktor.plugin` Gradle plugin version from 3.2.0 to 3.2.1 |
| codeSnippets/snippets/tutorial-server-docker-compose/build.gradle.kts | Updated `io.ktor.plugin` Gradle plugin version from 3.2.0 to 3.2.1; removed duplicate `com.h2database:h2` dependency |
| codeSnippets/snippets/auth-oauth-google/src/test/kotlin/ApplicationTest.kt | Modified test mock response: reduced `UserInfo` object parameters from six to four |
| topics/releases.md | Added 3.2.1 release entry with summary, date, and details directive |
## Possibly related PRs
- ktorio/ktor-documentation#647: Updates Ktor version from 3.1.3 to 3.2.0, similar version bump but no overlapping code-level changes beyond version updates.
## Suggested reviewers
- Stexxe
- bjhham 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (6)
codeSnippets/snippets/engine-main-custom-environment/build.gradle.kts (1)
7-7
: Same note as above regardingktor_version
consistencySee previous comment – keep the property/value aligned across the repo.
codeSnippets/snippets/tutorial-server-web-application/build.gradle.kts (1)
8-8
: Same note as above regardingktor_version
consistencySee previous comment – keep the property/value aligned across the repo.
codeSnippets/snippets/deployment-ktor-plugin/build.gradle.kts (1)
4-8
: Same observation as in the proguard snippet: consider extracting the plugin version to a shared location to avoid repetitive edits.codeSnippets/snippets/tutorial-website-static/build.gradle.kts (1)
5-9
: See earlier note about avoiding per-module hard-coding of"3.2.1"
.codeSnippets/snippets/legacy-interactive-website/build.gradle.kts (1)
4-8
: Version literal duplication noted previously; centralizing it would ease maintenance.codeSnippets/snippets/aws-elastic-beanstalk/build.gradle.kts (1)
3-7
: Repeat of prior comment regarding plugin version centralization.
🧹 Nitpick comments (6)
codeSnippets/snippets/htmx-integration/build.gradle.kts (1)
21-27
: Remove duplicatektor-server-core
dependency.Both of these lines pull in the same module, differing only by the explicit
-jvm
suffix. This will resolve to two identical artifacts in the class-path:implementation("io.ktor:ktor-server-core-jvm") // line 22 implementation("io.ktor:ktor-server-core") // line 25Retain just one (prefer the explicit
-jvm
variant for clarity) to avoid needless duplication:implementation("io.ktor:ktor-server-core-jvm") -implementation("io.ktor:ktor-server-core")
codeSnippets/snippets/server-websockets-sharedflow/build.gradle.kts (1)
8-8
: Consider sourcing the plugin version from the samektor_version
property
Hard-coding the plugin version forces manual edits in every snippet on the next upgrade. You can reference the already-defined project property (or a version catalog alias) to keep the value single-sourced:- id("io.ktor.plugin") version "3.2.1" + id("io.ktor.plugin") version ktor_versionThis works if the version is exposed via
settings.gradle.kts
/pluginManagement
orlibs.versions.toml
.codeSnippets/snippets/tutorial-server-restful-api/build.gradle.kts (1)
8-8
: Same single-sourcing suggestion applies here
Duplicated literal makes future bumps noisy; re-use the central version variable or catalog alias to stay DRY:- id("io.ktor.plugin") version "3.2.1" + id("io.ktor.plugin") version ktor_versioncodeSnippets/snippets/tutorial-server-websockets/build.gradle.kts (1)
7-7
: Ktor plugin bumped; double-check companion plugin compatibility
io.ktor.plugin
is now3.2.1
, whileorg.jetbrains.kotlin.plugin.serialization
stays at2.1.20
. If the project Kotlin version remains 2.1.20 that’s fine; otherwise consider updating the serialization plugin in tandem.codeSnippets/snippets/tutorial-server-docker-compose/build.gradle.kts (1)
11-11
: Version bump OK; minor clean-up opportunity noticedUpgrade looks good. While here, note that
com.h2database:h2
appears twice in the dependencies list (lines 34 & 38) – you can safely remove one occurrence.codeSnippets/snippets/proguard/build.gradle.kts (1)
17-21
: Centralize the Ktor plugin versionHard-coding
"3.2.1"
in every snippet forces N-way edits at the next patch bump. Move the version to a single source of truth (e.g.,gradle.properties
,pluginManagement { plugins { … } }
, or a version catalog) and reference it here to keep upgrades friction-free.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (24)
codeSnippets/gradle.properties
(1 hunks)codeSnippets/snippets/auth-oauth-google/src/test/kotlin/ApplicationTest.kt
(1 hunks)codeSnippets/snippets/aws-elastic-beanstalk/build.gradle.kts
(1 hunks)codeSnippets/snippets/deployment-ktor-plugin/build.gradle.kts
(1 hunks)codeSnippets/snippets/engine-main-custom-environment/build.gradle.kts
(1 hunks)codeSnippets/snippets/forwarded-header/build.gradle.kts
(1 hunks)codeSnippets/snippets/htmx-integration/build.gradle.kts
(1 hunks)codeSnippets/snippets/legacy-interactive-website/build.gradle.kts
(1 hunks)codeSnippets/snippets/proguard/build.gradle.kts
(1 hunks)codeSnippets/snippets/server-websockets-sharedflow/build.gradle.kts
(1 hunks)codeSnippets/snippets/tutorial-client-kmm/gradle/libs.versions.toml
(1 hunks)codeSnippets/snippets/tutorial-server-db-integration/gradle/libs.versions.toml
(1 hunks)codeSnippets/snippets/tutorial-server-docker-compose/build.gradle.kts
(1 hunks)codeSnippets/snippets/tutorial-server-get-started-maven/pom.xml
(1 hunks)codeSnippets/snippets/tutorial-server-get-started/build.gradle.kts
(1 hunks)codeSnippets/snippets/tutorial-server-restful-api/build.gradle.kts
(1 hunks)codeSnippets/snippets/tutorial-server-routing-and-requests/build.gradle.kts
(1 hunks)codeSnippets/snippets/tutorial-server-web-application/build.gradle.kts
(1 hunks)codeSnippets/snippets/tutorial-server-websockets/build.gradle.kts
(1 hunks)codeSnippets/snippets/tutorial-website-static/build.gradle.kts
(1 hunks)help-versions.json
(1 hunks)project.ihp
(1 hunks)topics/releases.md
(1 hunks)v.list
(1 hunks)
🔇 Additional comments (11)
codeSnippets/snippets/tutorial-server-get-started/build.gradle.kts (1)
5-9
: Confirmktor_version
property bump as well.The plugin was bumped to 3.2.1, but the script still relies on the separate
ktor_version
property for the library coordinates below (lines 21–27).
Double-check thatcodeSnippets/gradle.properties
(or the parentgradle.properties
) now contains:ktor_version=3.2.1
to avoid a plugin-library version mismatch at compile time.
If it is already updated globally, you can disregard this note.codeSnippets/snippets/forwarded-header/build.gradle.kts (1)
4-9
: 👍 Version bump looks correct.
No further issues spotted; the snippet depends exclusively on the plugin-managed BOM so the single line change is sufficient.codeSnippets/snippets/tutorial-client-kmm/gradle/libs.versions.toml (1)
1-7
: Consistent with plugin update – looks good.
Ensure any Gradle-plugin declarations in the KMP sub-modules (if present) are also bumped to 3.2.1 to keep the catalog and build scripts in sync.help-versions.json (1)
12-16
: Docs version switch updated correctly.The new entry is marked
isCurrent=true
; no JSON schema or SEO issues detected.codeSnippets/gradle.properties (1)
9-9
: Ktor version bump LGTM
Patch-level upgrade to 3.2.1 matches the coordinated plugin bumps elsewhere; low-risk and backwards-compatible.codeSnippets/snippets/tutorial-server-db-integration/gradle/libs.versions.toml (1)
6-6
: Version catalog updated correctly
Patch bump is consistent with other files and keeps all module coordinates aligned.project.ihp (1)
17-17
: Docs instance points to the new release – looks good
Site generator will now publish against 3.2.1.codeSnippets/snippets/tutorial-server-get-started-maven/pom.xml (1)
11-11
: LGTM! Clean version bump to patch release.The update to Ktor 3.2.1 is consistent with the patch release nature and properly uses Maven variable substitution for all Ktor dependencies.
v.list (1)
7-7
: LGTM! Version variable updated consistently.The ktor_version variable update to 3.2.1 aligns with the project-wide version bump and maintains consistency across configuration files.
codeSnippets/snippets/auth-oauth-google/src/test/kotlin/ApplicationTest.kt (1)
43-43
: Constructor signature verified against Application.ktThe test’s
UserInfo("1", "JetBrains", "", "")
call matches the 4-parameterdata class UserInfo
in
codeSnippets/snippets/auth-oauth-google/src/main/kotlin/com/example/oauth/google/Application.kt
. No further changes required—approving this update.topics/releases.md (1)
36-43
: LGTM! Comprehensive release documentation added.The new release entry for version 3.2.1 is well-structured and provides clear information about the patch release content, including specific improvements and bug fixes. The format is consistent with existing entries.
No description provided.