-
Notifications
You must be signed in to change notification settings - Fork 331
Update kxrpc tutorial to 0.8.1 #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe build configuration for the Kotlin RPC tutorial application was updated to reference version 0.8.1 of the org.jetbrains.kotlinx.rpc.plugin plugin and all associated kotlinx-rpc-krpc dependencies, replacing the previous version 0.8.0. No other build settings or dependencies were modified. Changes
Possibly related PRs
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
codeSnippets/snippets/tutorial-kotlin-rpc-app/build.gradle.kts (1)
5-5
: Hard-code → constant to avoid future version skewThe
0.8.1
literal now repeats in five places below. Extract it to a singleval rpcVersion = "0.8.1"
(or alibs.versions.toml
entry if you use Version Catalog) and reference it from both the plugin block and the dependencies block. This prevents silent diverging versions on the next bump and improves maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
codeSnippets/snippets/tutorial-kotlin-rpc-app/build.gradle.kts
(2 hunks)
🔇 Additional comments (1)
codeSnippets/snippets/tutorial-kotlin-rpc-app/build.gradle.kts (1)
17-22
: Verify that every artifact for 0.8.1 is published & compatible with Ktor 3.2While the bump looks consistent,
kotlinx-rpc-krpc-ktor-*
coordinates occasionally lag Maven Central propagation. Please run a quick resolution check (e.g../gradlew dependencies
) before merging to avoid CI breakage, especially given the mix of Kotlin 2.2.0 and Ktor 3.2.0.
Version bump to
0.8.1