fix: add --leader-elect flags back by reverting https://github.com/kubernetes/autoscaler/pull/7233
#7761
Conversation
kubernetes#7233 broke `--leader-elect` flag by introducing `--lease-resource-name` that is redundant with `--leader-elect-resource-name`
…ns in kube_flag.InitFlags()
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @idebeijer. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
cncf-cla: yes
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: idebeijer, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…bernetes#7761) * fix: move leader elect flag binding above InitFlags() * Revert kubernetes#7233 kubernetes#7233 broke `--leader-elect` flag by introducing `--lease-resource-name` that is redundant with `--leader-elect-resource-name` * fix: move leader election flag binding above flag parsing which happens in kube_flag.InitFlags() --------- Co-authored-by: Daniel Kłobuszewski <[email protected]>
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix for #7668. In commit c382519 the binding of the leader election flags was moved under
kube_flag.InitFlags()which is responsible for parsing the flags. This resulted in the leader election flags not being known anymore when starting the cluster-autoscaler. Trying to pass any of the--leader-electflags would fail and crash it:unknown flag: --leader-elect.By moving the binding of the flag above parsing (
kube_flag.InitFlags()) like it used to be, the flags are available again.Which issue(s) this PR fixes:
Fixes #7668
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: