Skip to content

Add ianychoi to sig-docs-ko-*#5374

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
ianychoi:add-ianychoi-to-sig-docs-ko
May 6, 2025
Merged

Add ianychoi to sig-docs-ko-*#5374
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
ianychoi:add-ianychoi-to-sig-docs-ko

Conversation

@ianychoi
Copy link
Member

I'd like to re-apply for sig-docs-ko-owners & sig-docs-ko-reviews role.

I had sig-docs-ko-owners & sig-docs-ko-reviews roles by 2023.
After stabilizing some personal status through 2025(moving job position), I would like to re-apply for the roles to facilitate Korean L10n progress.

Thank you for the discussion @seokho-son , and appreciate so much in advance if you are supportive on this PR.

Note that this PR aligns with kubernetes/website#49551

This commit adds ianychoi to sig-docs-ko-owners and
sig-docs-ko-reviews
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Jan 25, 2025
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 25, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @ianychoi!

It looks like this is your first PR to kubernetes/org 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/org has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @ianychoi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 25, 2025
@seokho-son
Copy link
Member

Welcome back @ianychoi !
As one of Korean localization approvers, I am sure @ianychoi is eligible for these roles.

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2025
@ianychoi
Copy link
Member Author

ianychoi commented Mar 3, 2025

Hi @reylejano, would you kindly review this PR? Appreciate in advance!

@stmcginnis
Copy link
Contributor

/lgtm

🎉

@sftim
Copy link

sftim commented Mar 9, 2025

/ok-to-test

config_test.go:268: The following members of team sig-docs-ko-owners are not Kubernetes org members: ianychoi 

Is that true?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2025
@sftim
Copy link

sftim commented Mar 9, 2025

@ianychoi make sure you're a member of the Kubernetes org; if you're not, you need to visit https://github.com/kubernetes/org/issues/new/choose and pick Organization Membership Request. You'll need to do that even if you were previously a member.

I'll happily sponsor you BTW, but I am AFK a lot in the upcoming weeks.

귀하의 문서화 노력에 감사드립니다 (I hope that's right).

@ianychoi
Copy link
Member Author

/retest-required

@seokho-son
Copy link
Member

Hi @reylejano @divya-mohan0209
PTAL this PR to add a new Korean approver/reviewer, and the aligned PR in k/website. kubernetes/website#49551

@divya-mohan0209
Copy link
Contributor

Hey @seokho-son I am happy to add @ianychoi to the org
/lgtm

@Priyankasaggu11929
Copy link
Member

we're good here from the org membership requirement side.

cc: @kubernetes/sig-docs-leads for final approval. Thanks!

@divya-mohan0209
Copy link
Contributor

LGTM from my side, @Priyankasaggu11929!

@Priyankasaggu11929
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ianychoi, Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2ec4c4d into kubernetes:main May 6, 2025
4 checks passed
@ianychoi ianychoi mentioned this pull request Aug 21, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants