Skip to content

Add ianychoi to sig-docs-ko-owners & sig-docs-ko-reviews #49551

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
ianychoi:add-ianychoi-to-sig-docs-ko
Apr 16, 2025
Merged

Add ianychoi to sig-docs-ko-owners & sig-docs-ko-reviews #49551
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
ianychoi:add-ianychoi-to-sig-docs-ko

Conversation

@ianychoi
Copy link
Member

@ianychoi ianychoi commented Jan 25, 2025

I'd like to re-apply for sig-docs-ko-owners & sig-docs-ko-reviews role.

I had sig-docs-ko-owners & sig-docs-ko-reviews roles by 2023 (I was removed through #43975 ).
After stabilizing some personal status through 2024 (moving job position), I would like to re-apply for the roles to facilitate Korean L10n progress.

Thank you for the discussion @seokho-son , and appreciate so much in advance if you are supportive on this PR.

It aligns with kubernetes/org#5374 PR on kubernetes/org repo.

Note that I've met the requirements for reviewer:

  • Member of Kubernetes for 3+ months
  • Primary reviewer for at least 5 PRs to the codebase
  • Reviewed or merged at least 20 substantial PRs to the codebase

This commit adds ianychoi to sig-docs-ko-owners
and sig-docs-ko-reviews
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2025
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 25, 2025
@k8s-ci-robot k8s-ci-robot requested a review from tengqm January 25, 2025 01:34
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 25, 2025
@ianychoi
Copy link
Member Author

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing /verify-owners in a comment.

  • ianychoi

    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

Please refer to kubernetes/org#5374 thank you.

@netlify
Copy link

netlify bot commented Jan 25, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5a87a2e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67943f96b784cb0008387ba9
😎 Deploy Preview https://deploy-preview-49551--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@seokho-son
Copy link
Member

Welcome back @ianychoi !
As one of Korean localization approvers, I am sure @ianychoi is eligible for these roles.

@ianychoi
Copy link
Member Author

ianychoi commented Mar 3, 2025

Hi @katcosgrove and @tengqm (per assigned reviewers for this PR), would you kindly review this PR?
Appreciate in advance!

@seokho-son
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: a46a322da0bed779aece41fdb4d31560665a9e4a

@divya-mohan0209
Copy link
Contributor

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 16, 2025
@divya-mohan0209
Copy link
Contributor

Thanks @ianychoi for your patience!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit aee845d into kubernetes:main Apr 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants