chore: delete OAuth support for CLI

[rangoo94]

Pull request description

• fix: refresh token in CLI properly / chore: delete unused OAuth support for direct Kubernetes communication testkube#6013

Checklist (choose whats happened)

• breaking change! (describe)
• tested locally
• tested on cluster
• added new dependencies
• updated the docs
• added a test

[thradec]

Hi, we were using direct cli access without oauth and now the ingress definition is gone. Is direct access still supported?

[vsukhin]

hey, @thradec No, direct access feature was not touched, we just remove existed cli oauth support, because it was limited and it looked like no one used it. Do you think ingress definition is useful for you in our helm chart @rangoo94 @ypoplavs ?

[rangoo94]

I don't think CLI ingress was used for it - from what I know, direct was using simply direct URL - often pointed to testkube-api-server service. I won't be next to the computer though today, so I'm not able to confirm.

[thradec]

Hi, we were using direct access and call testkube api from outside the cluster, so the calls go through ingress which is exposing the api. Or should we migrate to ui-ingress now?

For context, this is the example how we are using it:

$ testkube --client direct --api-uri https://<cluster-hostname>/testkube/api run tw <test-workflow>

[rangoo94]

@emil2k, @ypoplavs - could you recommend?

We've been earlier having Ingress created based on the cliIngress property. I'm not sure what was the original intent around that - I'm not sure if it's safe to expose it this way. It was not enabled by default though.

We can either:

• add it back, and just delete oauth configuration from there
• recommend adding Ingress resource separately

I think that it may be better to add Ingress separately, but I have limited knowledge about that.

[rangoo94]

@emil2k, @ypoplavs - if you think that it's fine to keep cliIngress property, I have prepared helm-charts#962 PR that will add this functionality back 👍

[rangoo94]

@thradec - I have added back cliIngress, as it seems to not cause any problems as it's disabled by default. The newest Helm Charts should work fine for you 👍

[thradec]

Thanks a lot! ❤️