Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete OAuth support for CLI #956

Merged
merged 1 commit into from
Nov 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/helm-releaser-testkube-charts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ jobs:
# Deploy the Docker image to the GKE cluster
- name: Deploy
run: |-
helm upgrade --install --atomic --timeout 180s testkube helm-charts/testkube --namespace testkube-integration --create-namespace --values ./charts/testkube/values-stage.yaml --debug --set testkube-api.cliIngress.oauth.clientID=${{ secrets.TESTKUBE_DEMO_OAUTH_CLIENT_ID }} --set testkube-api.cliIngress.oauth.clientSecret=${{ secrets.TESTKUBE_DEMO_OAUTH_CLIENT_SECRET }} --set mongodb.livenessProbe.enabled=false --set mongodb.readinessProbe.enabled=false --set testkube-operator.enabled=false
helm upgrade --install --atomic --timeout 180s testkube helm-charts/testkube --namespace testkube-integration --create-namespace --values ./charts/testkube/values-stage.yaml --debug --set mongodb.livenessProbe.enabled=false --set mongodb.readinessProbe.enabled=false --set testkube-operator.enabled=false

notify_slack_if_deploy_dev_succeeds:
runs-on: ubuntu-latest
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ jobs:
# Deploy the Docker image to the GKE cluster
- name: Deploy
run: |-
helm upgrade --install --atomic --timeout 180s testkube helm-charts/testkube --namespace testkube-integration --create-namespace --values ./charts/testkube/values-stage.yaml --debug --set testkube-api.cliIngress.oauth.clientID=${{ secrets.TESTKUBE_DEMO_OAUTH_CLIENT_ID }} --set testkube-api.cliIngress.oauth.clientSecret=${{ secrets.TESTKUBE_DEMO_OAUTH_CLIENT_SECRET }} --set mongodb.livenessProbe.enabled=false --set mongodb.readinessProbe.enabled=false --set testkube-operator.enabled=false
helm upgrade --install --atomic --timeout 180s testkube helm-charts/testkube --namespace testkube-integration --create-namespace --values ./charts/testkube/values-stage.yaml --debug --set mongodb.livenessProbe.enabled=false --set mongodb.readinessProbe.enabled=false --set testkube-operator.enabled=false

notify_slack_if_deploy_dev_succeeds:
runs-on: ubuntu-latest
Expand Down
11 changes: 0 additions & 11 deletions charts/testkube-api/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,6 @@ A Helm chart for Testkube api
| autoscaling.targetCPUUtilizationPercentage | int | `80` | |
| autoscaling.targetMemoryUtilizationPercentage | int | `80` | |
| cdeventsTarget | string | `""` | |
| cliIngress.annotations | object | `{}` | |
| cliIngress.enabled | bool | `false` | |
| cliIngress.hosts | list | `[]` | |
| cliIngress.labels | object | `{}` | |
| cliIngress.oauth.clientID | string | `""` | |
| cliIngress.oauth.clientSecret | string | `""` | |
| cliIngress.oauth.provider | string | `"github"` | |
| cliIngress.oauth.scopes | string | `""` | |
| cliIngress.path | string | `"/results/(v\\d/.*)"` | |
| cliIngress.tls | list | `[]` | |
| cliIngress.tlsenabled | bool | `false` | |
| cloud.envId | string | `""` | |
| cloud.existingSecret.envId | string | `""` | |
| cloud.existingSecret.key | string | `""` | |
Expand Down
58 changes: 0 additions & 58 deletions charts/testkube-api/templates/cli-ingress.yaml

This file was deleted.

26 changes: 0 additions & 26 deletions charts/testkube-api/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -627,32 +627,6 @@ uiIngress:
# - testkube.example.com
# secretName: testkube-cert-secret

## cliIngress parameters
cliIngress:
## Use cliIngress
enabled: false
## Labels to add to the Ingress
labels: {}
## Annotations to add to the Ingress
annotations: {}
## Parameters to check oauth token (by default github one)
oauth:
clientID: ""
clientSecret: ""
provider: "github"
scopes: ""
## The Path to Nginx.
path: /results/(v\d/.*)
## Hostnames must be provided if Ingress is enabled.
hosts: []
# - testkube.example.com
tlsenabled: false
# Placing a host in the TLS config will indicate a certificate should be created
tls: []
# - hosts:
# - testkube.example.com
# secretName: testkube-cert-secret

## Prometheus monitoring
prometheus:
## Toggle whether to install ServiceMonitor
Expand Down
10 changes: 0 additions & 10 deletions charts/testkube/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -219,16 +219,6 @@ kubectl label --overwrite crds scripts.tests.testkube.io app.kubernetes.io/manag
| testkube-api.additionalVolumes | list | `[]` | Additional volumes to be added |
| testkube-api.analyticsEnabled | bool | `true` | Enable analytics for Testkube |
| testkube-api.cdeventsTarget | string | `""` | target for cdevents emission via http(s) |
| testkube-api.cliIngress.annotations | object | `{}` | Additional annotations for the Ingress resource. |
| testkube-api.cliIngress.enabled | bool | `false` | Use ingress |
| testkube-api.cliIngress.hosts | list | `["testkube.example.com"]` | Hostnames must be provided if Ingress is enabled. |
| testkube-api.cliIngress.oauth.clientID | string | `""` | OAuth Client ID |
| testkube-api.cliIngress.oauth.clientSecret | string | `""` | OAuth Client Secret |
| testkube-api.cliIngress.oauth.provider | string | `"github"` | OAuth Provider |
| testkube-api.cliIngress.oauth.scopes | string | `""` | OAuth Scopes |
| testkube-api.cliIngress.path | string | `"/results/(v\\d/.*)"` | |
| testkube-api.cliIngress.tls | list | `[]` | Placing a host in the TLS config will indicate a certificate should be created |
| testkube-api.cliIngress.tlsenabled | bool | `false` | Toggle whether to enable TLS on the ingress |
| testkube-api.cloud.key | string | `""` | Testkube Clouc License Key (for Environment) |
| testkube-api.cloud.tls.certificate.caFile | string | `"/tmp/agent-cert/ca.crt"` | Default path for ca file |
| testkube-api.cloud.tls.certificate.certFile | string | `"/tmp/agent-cert/cert.crt"` | Default path for certificate file |
Expand Down
23 changes: 0 additions & 23 deletions charts/testkube/values-demo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -292,29 +292,6 @@ testkube-api:
- hosts:
- demo.testkube.io
secretName: testkube-demo-cert-secret
cliIngress:
enabled: true
annotations:
kubernetes.io/ingress.class: nginx
nginx.ingress.kubernetes.io/rewrite-target: /$1
nginx.ingress.kubernetes.io/force-ssl-redirect: "true"
nginx.ingress.kubernetes.io/ssl-redirect: "true"
nginx.ingress.kubernetes.io/configuration-snippet: |
more_set_input_headers "X-CLI-Ingress: true";
# parameters to check oauth token (by default github one)
oauth:
clientID: ""
clientSecret: ""
provider: "github"
scopes: ""
path: /api/(v\d/.*)
hosts:
- demo.testkube.io
tlsenabled: "false"
tls: # < placing a host in the TLS config will indicate a certificate should be created
- hosts:
- demo.testkube.io
secretName: testkube-demo-cert-secret
storage:
endpoint: ""
endpoint_port: "9000"
Expand Down
23 changes: 0 additions & 23 deletions charts/testkube/values-develop.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -237,29 +237,6 @@ testkube-api:
- hosts:
- demo.testkube.dev
secretName: testkube-prod-cert-secret
cliIngress:
enabled: false
annotations:
kubernetes.io/ingress.class: nginx
nginx.ingress.kubernetes.io/rewrite-target: /$1
nginx.ingress.kubernetes.io/force-ssl-redirect: "false"
nginx.ingress.kubernetes.io/ssl-redirect: "false"
nginx.ingress.kubernetes.io/configuration-snippet: |
more_set_headers "X-CLI-Ingress: true";
# parameters to check oauth token (by default github one)
oauth:
clientID: ""
clientSecret: ""
provider: "github"
scopes: ""
path: /results/(v\d/.*)
hosts:
- demo.testkube.dev
tlsenabled: "false"
tls: # < placing a host in the TLS config will indicate a certificate should be created
- hosts:
- demo.testkube.dev
secretName: testkube-prod-cert-secret
storage:
endpoint: ""
endpoint_port: "9000"
Expand Down
23 changes: 0 additions & 23 deletions charts/testkube/values-stage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -236,29 +236,6 @@ testkube-api:
- hosts:
- demo.testkube.xyz
secretName: testkube-demo-cert-secret
cliIngress:
enabled: false
annotations:
kubernetes.io/ingress.class: nginx
nginx.ingress.kubernetes.io/rewrite-target: /$1
nginx.ingress.kubernetes.io/force-ssl-redirect: "false"
nginx.ingress.kubernetes.io/ssl-redirect: "false"
nginx.ingress.kubernetes.io/configuration-snippet: |
more_set_headers "X-CLI-Ingress: true";
# parameters to check oauth token (by default github one)
oauth:
clientID: ""
clientSecret: ""
provider: "github"
scopes: ""
path: /results/(v\d/.*)
hosts:
- demo.testkube.io
tlsenabled: "false"
tls: # < placing a host in the TLS config will indicate a certificate should be created
- hosts:
- demo.testkube.io
secretName: testkube-demo-cert-secret
storage:
endpoint: ""
endpoint_port: "9000"
Expand Down
40 changes: 0 additions & 40 deletions charts/testkube/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -685,46 +685,6 @@ testkube-api:
# - testkube.example.com
# secretName: testkube-cert-secret

# cliIngress parameters
cliIngress:
# -- Use ingress
enabled: false
# -- Additional annotations for the Ingress resource.
annotations: {}
# e.g. annotations for NGINX Ingress Controller:
# kubernetes.io/ingress.class: nginx
# nginx.ingress.kubernetes.io/rewrite-target: /$1
# nginx.ingress.kubernetes.io/force-ssl-redirect: "false"
# nginx.ingress.kubernetes.io/ssl-redirect: "false"
# nginx.ingress.kubernetes.io/configuration-snippet: |
# more_set_headers "X-CLI-Ingress: true";
# for websockets
# nginx.ingress.kubernetes.io/proxy-read-timeout: "3600"
# nginx.ingress.kubernetes.io/proxy-send-timeout: "3600"

# parameters to check oauth token (by default github one)
oauth:
# -- OAuth Client ID
clientID: ""
# -- OAuth Client Secret
clientSecret: ""
# -- OAuth Provider
provider: "github"
# -- OAuth Scopes
scopes: ""
path: /results/(v\d/.*)
# -- Hostnames must be provided if Ingress is enabled.
hosts:
- testkube.example.com
# -- Toggle whether to enable TLS on the ingress
tlsenabled: false
# -- Placing a host in the TLS config will indicate a certificate should be created
tls:
[]
# - hosts:
# - testkube.example.com
# secretName: testkube-cert-secret

# Storage for Testkube API using MinIO
storage:
# -- MinIO endpoint
Expand Down