-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing rbacs #54
Conversation
lanes failed due to backoff polling quay.io/kubevirtci/alpine-container-disk-demo:devel_alt /retest |
clean main is also broken #55 |
seems #56 fix main branch state |
Thanks Miguel, we would need please #56 first as it blocks the whole CI on this repo |
Lately blockOwnerDeletion was added (finalizer fix PR). On OpenShift there is an additional protection, that setting blockOwnerDeletion requires to be able to set finalizers on the owner. The owner might be either VM or VMI. Add the missing rbacs. Signed-off-by: Or Shoval <[email protected]>
rebased to take the main branch fix |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Lately
blockOwnerDeletion
was added (finalizer fix PR).On OpenShift there is an additional protection, that setting
blockOwnerDeletion
requiresto be able to set finalizers on the owner.
The owner might be either VM or VMI.
Add the missing rbacs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#ownerreferencespermissionenforcement
Seems it will be good to enable
OwnerReferencesPermissionEnforcement
on kind,ovn-kubernetes/ovn-kubernetes#4608
For now just used it to make sure i can simulate the bug on kind, and that this PR does solve it.
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: