-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prow jobs for publishing k8s provider multi arch images #3566
base: main
Are you sure you want to change the base?
Prow jobs for publishing k8s provider multi arch images #3566
Conversation
Hi @chandramerla. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc |
5f11ef5
to
b2931c9
Compare
b15707f
to
3eef8a7
Compare
3eef8a7
to
b15707f
Compare
/sig ci |
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml
Outdated
Show resolved
Hide resolved
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-postsubmits.yaml
Outdated
Show resolved
Hide resolved
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-postsubmits.yaml
Outdated
Show resolved
Hide resolved
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brianmcarey Thanks for your review immediately after your vacation :)
I've added initial replies/questions to your comments and would start doing changes.
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml
Outdated
Show resolved
Hide resolved
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-postsubmits.yaml
Outdated
Show resolved
Hide resolved
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml
Outdated
Show resolved
Hide resolved
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-postsubmits.yaml
Outdated
Show resolved
Hide resolved
be95072
to
858c1ee
Compare
858c1ee
to
1897bf9
Compare
8ecec41
to
a9e54df
Compare
3fbb6a4
to
7c53877
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brianmcarey Could you please review this PR again, I've tested all the changes locally and also updated with new pr-creator image now? Thanks for your inputs so far.
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-postsubmits.yaml
Outdated
Show resolved
Hide resolved
The pre-requisite for this PR i.e., a new bootstrap image to be rebuilt with changes are moved to a separate PR (#3648 ) |
7c53877
to
32cb318
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
32cb318
to
02f1a34
Compare
02f1a34
to
2b485df
Compare
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml
Outdated
Show resolved
Hide resolved
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-postsubmits.yaml
Show resolved
Hide resolved
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-postsubmits.yaml
Outdated
Show resolved
Hide resolved
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml
Outdated
Show resolved
Hide resolved
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-postsubmits.yaml
Outdated
Show resolved
Hide resolved
2b485df
to
d1f8db8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brianmcarey Done some changes and added question(s).
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml
Outdated
Show resolved
Hide resolved
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-postsubmits.yaml
Outdated
Show resolved
Hide resolved
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml
Outdated
Show resolved
Hide resolved
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-postsubmits.yaml
Outdated
Show resolved
Hide resolved
1c89200
to
ce0588b
Compare
/test all |
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml
Outdated
Show resolved
Hide resolved
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml
Outdated
Show resolved
Hide resolved
ce0588b
to
41f7f41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brianmcarey Addressed your latest comments. Thanks.
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml
Outdated
Show resolved
Hide resolved
github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml
Outdated
Show resolved
Hide resolved
Also updated x86 prow job to signal s390x job to continue and pass KUBEVIRTCI_TAG by creating a file in GCS Signed-off-by: chandramerla <[email protected]>
…s base for s390x and manifest-list Also modified periodic-kubevirtci-bump-centos-base (x86 job) to signal and pass KUBEVIRTCI_TAG to s390x job Signed-off-by: chandramerla <[email protected]>
41f7f41
to
98d8914
Compare
What this PR does / why we need it:
This PR adds multi-arch publish jobs for centos9 and k8s provider images.
As we've added s390x support in k8s provider (started with 1.30 slim), centos9 and gocli images as part of kubevirt/kubevirtci#1252, this PR does changes required in project-infra repo to enable the prow jobs for the same.
Special notes for your reviewer:
This PR makes sense to be merged along with changes said above.
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: