Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow jobs for publishing k8s provider multi arch images #3566

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chandramerla
Copy link
Contributor

@chandramerla chandramerla commented Aug 1, 2024

What this PR does / why we need it:
This PR adds multi-arch publish jobs for centos9 and k8s provider images.

As we've added s390x support in k8s provider (started with 1.30 slim), centos9 and gocli images as part of kubevirt/kubevirtci#1252, this PR does changes required in project-infra repo to enable the prow jobs for the same.

Special notes for your reviewer:
This PR makes sense to be merged along with changes said above.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Aug 1, 2024
@kubevirt-bot
Copy link
Contributor

Hi @chandramerla. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@brianmcarey
Copy link
Member

/cc

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2024
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2024
@chandramerla chandramerla force-pushed the prow-jobs-for-provider-multi-arch-images branch from 5f11ef5 to b2931c9 Compare August 26, 2024 10:51
@kubevirt-bot kubevirt-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 26, 2024
@chandramerla chandramerla force-pushed the prow-jobs-for-provider-multi-arch-images branch from b15707f to 3eef8a7 Compare August 26, 2024 19:40
@chandramerla chandramerla force-pushed the prow-jobs-for-provider-multi-arch-images branch from 3eef8a7 to b15707f Compare August 26, 2024 19:54
@chandramerla
Copy link
Contributor Author

/sig ci

@kubevirt-bot kubevirt-bot added the sig/ci Denotes an issue or PR as being related to sig-ci, marks changes to the CI system. label Aug 26, 2024
Copy link
Contributor Author

@chandramerla chandramerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianmcarey Thanks for your review immediately after your vacation :)

I've added initial replies/questions to your comments and would start doing changes.

@chandramerla chandramerla force-pushed the prow-jobs-for-provider-multi-arch-images branch from be95072 to 858c1ee Compare August 29, 2024 04:26
@chandramerla chandramerla force-pushed the prow-jobs-for-provider-multi-arch-images branch from 858c1ee to 1897bf9 Compare September 2, 2024 06:42
@chandramerla chandramerla force-pushed the prow-jobs-for-provider-multi-arch-images branch 2 times, most recently from 8ecec41 to a9e54df Compare September 10, 2024 23:48
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2024
@chandramerla chandramerla force-pushed the prow-jobs-for-provider-multi-arch-images branch from 3fbb6a4 to 7c53877 Compare September 13, 2024 15:27
Copy link
Contributor Author

@chandramerla chandramerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianmcarey Could you please review this PR again, I've tested all the changes locally and also updated with new pr-creator image now? Thanks for your inputs so far.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2024
@chandramerla
Copy link
Contributor Author

The pre-requisite for this PR i.e., a new bootstrap image to be rebuilt with changes are moved to a separate PR (#3648 )

@chandramerla chandramerla force-pushed the prow-jobs-for-provider-multi-arch-images branch from 7c53877 to 32cb318 Compare September 16, 2024 11:55
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vladikr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chandramerla chandramerla force-pushed the prow-jobs-for-provider-multi-arch-images branch from 32cb318 to 02f1a34 Compare September 16, 2024 13:20
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2024
@chandramerla chandramerla force-pushed the prow-jobs-for-provider-multi-arch-images branch from 02f1a34 to 2b485df Compare September 20, 2024 15:57
@chandramerla chandramerla force-pushed the prow-jobs-for-provider-multi-arch-images branch from 2b485df to d1f8db8 Compare September 26, 2024 18:59
Copy link
Contributor Author

@chandramerla chandramerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianmcarey Done some changes and added question(s).

@chandramerla chandramerla force-pushed the prow-jobs-for-provider-multi-arch-images branch 4 times, most recently from 1c89200 to ce0588b Compare September 28, 2024 10:45
@brianmcarey
Copy link
Member

/test all

@chandramerla chandramerla force-pushed the prow-jobs-for-provider-multi-arch-images branch from ce0588b to 41f7f41 Compare November 11, 2024 16:12
Copy link
Contributor Author

@chandramerla chandramerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianmcarey Addressed your latest comments. Thanks.

Also updated x86 prow job to signal s390x job to continue and pass KUBEVIRTCI_TAG by creating a file in GCS

Signed-off-by: chandramerla <[email protected]>
…s base for s390x and manifest-list

Also modified periodic-kubevirtci-bump-centos-base (x86 job) to signal and pass KUBEVIRTCI_TAG to s390x job

Signed-off-by: chandramerla <[email protected]>
@chandramerla chandramerla force-pushed the prow-jobs-for-provider-multi-arch-images branch from 41f7f41 to 98d8914 Compare November 11, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. sig/ci Denotes an issue or PR as being related to sig-ci, marks changes to the CI system. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants