-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added optional presubmit check-provision-k8s-1.30-s390x #3681
Added optional presubmit check-provision-k8s-1.30-s390x #3681
Conversation
Signed-off-by: chandramerla <[email protected]>
Hi @chandramerla. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @brianmcarey |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chandramerla: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
decoration_config: | ||
timeout: 3h0m0s | ||
labels: | ||
preset-docker-mirror-proxy: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry - I missed this in the initial review - the s390x cluster doesn't have the image proxy so this preset will cause the job to fail to schedule.
Can you remove this preset in a follow up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brianmcarey Any doc which I can read to know more about docker mirror proxy use-case we use it for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doc gives an overview of the services we use on the main clusters - https://github.com/kubevirt/project-infra/blob/main/docs/infrastructure-components.md
What this PR does / why we need it:
This PR adds optional presubmit prow job named check-provision-k8s-1.30-s390x, which is used for checking the provisioning of k8s 1.30 provider on s390x arch. As we've a PR #1252 enabling k8s 1.30 provider on s390x, this prow job once merged can be used in that job as presubmit check.
Special notes for your reviewer:
Created the PR as discussed here
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: