Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional presubmit check-provision-k8s-1.30-s390x #3681

Merged

Conversation

chandramerla
Copy link
Contributor

What this PR does / why we need it:
This PR adds optional presubmit prow job named check-provision-k8s-1.30-s390x, which is used for checking the provisioning of k8s 1.30 provider on s390x arch. As we've a PR #1252 enabling k8s 1.30 provider on s390x, this prow job once merged can be used in that job as presubmit check.

Special notes for your reviewer:
Created the PR as discussed here

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Sep 28, 2024
@kubevirt-bot
Copy link
Contributor

Hi @chandramerla. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chandramerla
Copy link
Contributor Author

/cc @brianmcarey
/sig ci

@kubevirt-bot kubevirt-bot added the sig/ci Denotes an issue or PR as being related to sig-ci, marks changes to the CI system. label Sep 28, 2024
@brianmcarey
Copy link
Member

/test all

Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
@kubevirt-bot kubevirt-bot merged commit 5dd7d40 into kubevirt:main Sep 30, 2024
5 checks passed
@kubevirt-bot
Copy link
Contributor

@chandramerla: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirtci-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-presubmits.yaml

In response to this:

What this PR does / why we need it:
This PR adds optional presubmit prow job named check-provision-k8s-1.30-s390x, which is used for checking the provisioning of k8s 1.30 provider on s390x arch. As we've a PR #1252 enabling k8s 1.30 provider on s390x, this prow job once merged can be used in that job as presubmit check.

Special notes for your reviewer:
Created the PR as discussed here

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

decoration_config:
timeout: 3h0m0s
labels:
preset-docker-mirror-proxy: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - I missed this in the initial review - the s390x cluster doesn't have the image proxy so this preset will cause the job to fail to schedule.

Can you remove this preset in a follow up?

Copy link
Contributor Author

@chandramerla chandramerla Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianmcarey

I've created this PR #3684

Do we've to remove this label also for publish provider jobs for s390x at #3566 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianmcarey Any doc which I can read to know more about docker mirror proxy use-case we use it for?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc gives an overview of the services we use on the main clusters - https://github.com/kubevirt/project-infra/blob/main/docs/infrastructure-components.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. sig/ci Denotes an issue or PR as being related to sig-ci, marks changes to the CI system. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants