Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added optional presubmit check-provision-k8s-1.30-s390x #3681

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Added optional presubmit check-provision-k8s-1.30-s390x #3681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,31 @@ presubmits:
privileged: true
nodeSelector:
type: bare-metal-external
- always_run: false
cluster: prow-s390x-workloads
decorate: true
decoration_config:
timeout: 3h0m0s
labels:
preset-docker-mirror-proxy: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - I missed this in the initial review - the s390x cluster doesn't have the image proxy so this preset will cause the job to fail to schedule.

Can you remove this preset in a follow up?

Copy link
Contributor Author

@chandramerla chandramerla Sep 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianmcarey

I've created this PR #3684

Do we've to remove this label also for publish provider jobs for s390x at #3566 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianmcarey Any doc which I can read to know more about docker mirror proxy use-case we use it for?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc gives an overview of the services we use on the main clusters - https://github.com/kubevirt/project-infra/blob/main/docs/infrastructure-components.md

preset-kubevirtci-check-provision-env: "true"
preset-podman-in-container-enabled: "true"
max_concurrency: 1
name: check-provision-k8s-1.30-s390x
spec:
containers:
- command:
- /usr/local/bin/runner.sh
- /bin/sh
- -c
- cd cluster-provision/k8s/1.30 && ../provision.sh
image: quay.io/kubevirtci/golang:v20240923-918320b
name: ""
resources:
requests:
memory: 8Gi
securityContext:
privileged: true
- always_run: true
cluster: kubevirt-prow-workloads
decorate: true
Expand Down