New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting default setting, minor fixes #82

Merged

AvantiShri merged 2 commits into master from bugfix

Feb 3, 2021

Collaborator

AvantiShri commented Feb 3, 2021 •

edited

Loading

Default settings for variable-length seqlet identification seem not-great, so reverting to the previous default of fixed-length seqlet identification (which has been battle-tested more)
Putting in the fix caught by Bug in checking weights sum to 1 #81
Another minor fix for cases where there are lots of ties in the scores during seqlet identification (which could occur with the variable-length seqlet identification)

AvantiShri added 2 commits

February 2, 2021 20:50


          fix pointed out by BeyondTheProof, other print statement, reverting d…

234c224

…efault sliding window size to be 21 like before


          bugfix for cases where there are lots of ties at the high end (e.g. w…

11c84dc

…ith ir transformation)

AvantiShri mentioned this pull request

Bug in checking weights sum to 1 #81

Open

AvantiShri merged commit 3e5f5e8 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet