-
Notifications
You must be signed in to change notification settings - Fork 18.5k
fix: i18n: standardize trigger events terminology in billing translations #28543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ions Signed-off-by: NeatGuyCoding <[email protected]>
Summary of ChangesHello @NeatGuyCoding, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the internationalization (i18n) of billing-related texts by unifying the terminology for 'trigger events' across Italian, Portuguese (Brazil), and Romanian translations. The changes ensure a more consistent and accurate user experience in these languages by correcting existing translations and addressing a specific typo, thereby improving clarity and standardization. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request standardizes the terminology for 'trigger events' in the billing translations for Italian, Portuguese, and Romanian. The changes are mostly correct and achieve the goal of unification. I've pointed out a minor capitalization inconsistency in the Portuguese translation to ensure it aligns with the other languages.
| usageTitle: 'EVENTOS DESENCADEADORES', | ||
| title: 'Atualize para desbloquear mais eventos de gatilho', | ||
| usageTitle: 'EVENTOS DE GATILHO', | ||
| title: 'Atualize para desbloquear mais Eventos de Gatilho', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with other languages and the original English text ('Upgrade to unlock more trigger events'), 'Eventos de Gatilho' should probably be in lowercase here as 'eventos de gatilho'. The term is part of a sentence, not a standalone title.
| title: 'Atualize para desbloquear mais Eventos de Gatilho', | |
| title: 'Atualize para desbloquear mais eventos de gatilho', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR standardizes the translation of "trigger events" terminology across Italian, Portuguese, and Romanian billing translation files to ensure consistency within each language. The changes fix a typo in Romanian and unify terminology that was previously inconsistent.
- Fixes Romanian typo from "TRIGER" to "DECLANȘATOARE"
- Standardizes Italian to consistently use "eventi di attivazione"
- Standardizes Portuguese to consistently use "Eventos de Gatilho" and translates "workflow" to "fluxo de trabalho"
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| web/i18n/ro-RO/billing.ts | Corrects typo "EVENIMENTE TRIGER" → "EVENIMENTE DECLANȘATOARE" in usageTitle |
| web/i18n/pt-BR/billing.ts | Standardizes "trigger events" to "Eventos de Gatilho" across multiple fields and translates "workflow" |
| web/i18n/it-IT/billing.ts | Standardizes "trigger events" to "Eventi di attivazione" across all occurrences |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| startNodes: { | ||
| unlimited: 'Gatilhos/workflow ilimitados', | ||
| unlimited: 'Gatilhos/fluxo de trabalho ilimitados', |
Copilot
AI
Nov 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term 'Gatilhos' should be standardized to 'Eventos de Gatilho' to maintain consistency with the other changes in this PR. The English version uses 'Triggers/workflow', which should translate to 'Eventos de Gatilho/fluxo de trabalho ilimitados' for consistency with line 100 and the rest of the file.
| unlimited: 'Gatilhos/fluxo de trabalho ilimitados', | |
| unlimited: 'Eventos de Gatilho/fluxo de trabalho ilimitados', |
| upgrade: 'Actualizare', | ||
| usageTitle: 'EVENIMENTE TRIGER', | ||
| usageTitle: 'EVENIMENTE DECLANȘATOARE', | ||
| description: 'Ai atins limita de declanșatoare de evenimente de flux de lucru pentru acest plan.', |
Copilot
AI
Nov 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase 'limita de declanșatoare de evenimente' is grammatically awkward in Romanian. It should be 'limita de evenimente declanșatoare' (moving the adjective after the noun) or 'limita evenimentelor declanșatoare' to match natural Romanian word order and be consistent with the English 'limit of workflow event triggers'.
| description: 'Ai atins limita de declanșatoare de evenimente de flux de lucru pentru acest plan.', | |
| description: 'Ai atins limita de evenimente declanșatoare de flux de lucru pentru acest plan.', |
Important
Fixes #<issue number>.Summary
Fix i18n: unify trigger events terminology in billing translations
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods