Updated package.py for singularity-eos to avoid spack.* constructs #492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I ran the following commands to install
singularity-eos
on macOS and Linux, but encountered an error:After researching online a bit, the problem seems to boil down to this offending line in
spack-repo/packages/singularity-eos/package.py
:Note that the
spack
module is not imported in the script. This PR fixes this by changing this line to:and adding the appropriate imports:
PR Checklist
I tried figuring out how to check if the code is properly formatted, but failed. I'd be happy to do it if you can provide me with instructions.
make format
command after configuring withcmake
.If preparing for a new release, in addition please check the following:
when='@main'
dependencies are updated to the release version in the package.py