Address some stuff reported/suggested by code analyzers by Saancreed · Pull Request #167 · leancodepl/contractsgenerator

Saancreed · 2025-05-19T12:53:19Z

Lots of more or less stupid changes to make the .NET analyzers happy. I know some of them might be controversial so feel free to fight me where appropriate 🥊

Dragemil · 2025-05-19T14:45:09Z

src/LeanCode.Contracts/Security/AuthorizeWhenAttribute.cs

-        return type.GetCustomAttributes<AuthorizeWhenAttribute>().Select(AuthorizerDefinition.Create).ToList();
-    }
+    public static List<AuthorizerDefinition> GetCustomAuthorizers(Type type) =>
+        [.. type.GetCustomAttributes<AuthorizeWhenAttribute>().Select(AuthorizerDefinition.Create)];


Not a fan of this syntax. Also this space after .. is weird for me, but that's probably a csharpier thing.

The space is indeed a CSharpier thing. Weird, but I don't hate it.

(Take a look at how CSharpier formats XML files like csprojs to see something truly cursed 🙈)

As for [.. foo] vs foo.ToBar(), I'm not opposed to keeping the latter but the former does have one major advantage: it does the right thing with a single syntax, for many collection types, as long as the type can be inferred from context. But maybe there's enough space to keep both of them, without favoring one over another?

Take a look at how CSharpier formats XML files like csprojs to see something truly cursed

What do you mean? I've used csharpier 1.0.x somewhere, and csprojs seemed fine? 🤨

I'm not opposed to keeping the latter but the former does have one major advantage: it does the right thing with a single syntax, for many collection types

Right, that's true. I'm not hugely opposed, might even convience myself to using it, so there's place for coexistence of both for sure.

What do you mean? I've used csharpier 1.0.x somewhere, and csprojs seemed fine? 🤨

contractsgenerator/examples/project/Directory.Build.targets

Lines 3 to 5 in cf1ac68

<TargetFrameworks Condition="$([MSBuild]::VersionLessThan('$(NETCoreAppMaximumVersion)', '9.0'))"

>net8.0</TargetFrameworks

>

I have somewhat mixed feelings about the [.. X.Select(Y)] - this mixes both the spread operator and LINQ and I don't really know what to think about it. [.. X] is great, but I don't know if the ~4 chars are worth using instead of X.Select(Y).ToList().

But I don't hate it also. So basically indifferent. ^^'

src/LeanCode.Contracts/Validation/ValidationResult.cs

Dragemil · 2025-05-19T14:50:08Z

src/LeanCode.ContractsGenerator.Tests/Generation/ObjectExtensionsTests.cs

    [Theory]
    [InlineData((byte)10)]
    [InlineData((sbyte)10)]
-    [InlineData((int)10)]
-    [InlineData((long)10)]
    [InlineData((short)10)]
-    [InlineData((uint)10)]
-    [InlineData((ulong)10)]
    [InlineData((ushort)10)]
+    [InlineData(10)]
+    [InlineData(10L)]
+    [InlineData(10U)]
+    [InlineData(10UL)]


The old one was consistent at least.

Yeah, except .NET complained that the cast in (int)10 was redundant. If only we had byte and short literals 😢

src/LeanCode.ContractsGenerator/Compilation/ContractsCompiler.cs

lukaszgarstecki · 2025-05-20T11:09:32Z

src/LeanCode.ContractsGenerator/Generation/ContractsGenerator.cs

+public class ContractsGenerator(CompiledContracts contracts)
 {
-    private readonly CompiledContracts contracts;
+    private readonly CompiledContracts contracts = contracts;

-    private readonly TypeRefFactory typeRef;
-
-    public ContractsGenerator(CompiledContracts contracts)
-    {
-        this.contracts = contracts;
-
-        typeRef = new(contracts);
-    }
+    private readonly TypeRefFactory typeRef = new(contracts);


Arguably this should not be changed to a primary constructor

I think I agree with Łukasz here. This should not be a primary ctor IMO.

But as with everything recently when it comes to syntax, I don't hate it also. ^^'

github-actions · 2025-05-20T11:27:08Z

Test Results

2 files ±0 2 suites ±0 45s ⏱️ ±0s
82 tests ±0 82 ✅ ±0 0 💤 ±0 0 ❌ ±0
178 runs ±0 178 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit ce2e5d0. ± Comparison against base commit cf1ac68.

♻️ This comment has been updated with latest results.

src/LeanCode.Contracts.Admin/AdminQuery.cs

src/LeanCode.Contracts/Binary.cs

jakubfijalkowski · 2025-05-29T14:30:20Z

src/LeanCode.Contracts/Security/AuthorizeWhenAttribute.cs

-        return type.GetCustomAttributes<AuthorizeWhenAttribute>().Select(AuthorizerDefinition.Create).ToList();
-    }
+    public static List<AuthorizerDefinition> GetCustomAuthorizers(Type type) =>
+        [.. type.GetCustomAttributes<AuthorizeWhenAttribute>().Select(AuthorizerDefinition.Create)];


I have somewhat mixed feelings about the [.. X.Select(Y)] - this mixes both the spread operator and LINQ and I don't really know what to think about it. [.. X] is great, but I don't know if the ~4 chars are worth using instead of X.Select(Y).ToList().

But I don't hate it also. So basically indifferent. ^^'

jakubfijalkowski · 2025-05-29T14:34:25Z

src/LeanCode.ContractsGenerator/Generation/ContractsGenerator.cs

+public class ContractsGenerator(CompiledContracts contracts)
 {
-    private readonly CompiledContracts contracts;
+    private readonly CompiledContracts contracts = contracts;

-    private readonly TypeRefFactory typeRef;
-
-    public ContractsGenerator(CompiledContracts contracts)
-    {
-        this.contracts = contracts;
-
-        typeRef = new(contracts);
-    }
+    private readonly TypeRefFactory typeRef = new(contracts);


I think I agree with Łukasz here. This should not be a primary ctor IMO.

But as with everything recently when it comes to syntax, I don't hate it also. ^^'

src/LeanCode.ContractsGenerator/Generation/ContractsGenerator.cs

src/LeanCode.ContractsGenerator/Generation/TypeRefFactory.cs

Saancreed requested a review from jakubfijalkowski May 19, 2025 12:53

Dragemil reviewed May 19, 2025

View reviewed changes

lukaszgarstecki approved these changes May 20, 2025

View reviewed changes

Dragemil approved these changes May 20, 2025

View reviewed changes

Saancreed mentioned this pull request May 20, 2025

Fix constants ignoring ExcludeFromContractsGenerationAttribute #169

Merged

Saancreed force-pushed the analyzer-issues branch from ec3e2a9 to 136568f Compare May 29, 2025 13:42

jakubfijalkowski approved these changes May 29, 2025

View reviewed changes

Address some stuff reported/suggested by code analyzers

ce2e5d0

Saancreed force-pushed the analyzer-issues branch from 136568f to ce2e5d0 Compare May 30, 2025 12:30

Saancreed merged commit d2604e8 into main May 30, 2025
4 checks passed

Saancreed deleted the analyzer-issues branch May 30, 2025 12:36

	<TargetFrameworks Condition="$([MSBuild]::VersionLessThan('$(NETCoreAppMaximumVersion)', '9.0'))"
	>net8.0</TargetFrameworks
	>

Conversation

Saancreed commented May 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented May 20, 2025 •

edited

Loading