Embed prebuilt eden-sdn VM image inside the container #1077
Conversation
milan-zededa
force-pushed
the
sdn-vm-image
branch
3 times, most recently
from
50edef7 to
48ac1be
Compare
pkg/edensdn/qemu.go
Outdated
| @@ -28,7 +28,7 @@ func (vm *SdnVMQemuRunner) Start() error { | |||
| var qemuCommand string | |||
| qemuOptions := "-display none -nodefaults -no-user-config " | |||
| qemuOptions += fmt.Sprintf("-serial chardev:char0 -chardev socket,id=char0,port=%d,"+ | |||
| "host=localhost,server,nodelay,nowait,telnet,logfile=%s ", | |||
| "host=localhost,server=on,nodelay=on,wait=off,telnet=on,logfile=%s ", | |||
There was a problem hiding this comment.
Are we bumping qemu version we're using on host? We have couple of places where we doing this template, ideally this should be aligned across whole code base, would it be possible for you to change it and update readme?
There was a problem hiding this comment.
This was added unintentionally. I run newer Qemu and was getting some annoying deprecated option warnings.
I removed this change since it is not really related to what this PR is about.
There was a problem hiding this comment.
Okay, I'll create an Issue to keep track of it
| @@ -79,12 +79,6 @@ func (openEVEC *OpenEVEC) StartEveQemu(tapInterface string) error { | |||
| if err != nil { | |||
| return fmt.Errorf("failed to get unused IP subnet: %w", err) | |||
| } | |||
| imageDir := filepath.Dir(cfg.Sdn.ImageFile) | |||
There was a problem hiding this comment.
You're saying we don't need firmware anymore on EVE?
There was a problem hiding this comment.
No EVE still uses UEFI, this part is for Eden-SDN VM.
But I moved it to a separate StartEdenSDN function now to avoid the confusion.
|
LGTM, minor comments, could you also please add in SDN readme how can I build and push image to my local registry? |
milan-zededa
force-pushed
the
sdn-vm-image
branch
from
48ac1be to
9291320
Compare
Done, documentation added. |
milan-zededa
force-pushed
the
sdn-vm-image
branch
from
9291320 to
2c982e2
Compare
Previously, the lfedge/eden-sdn container included only the SDN service layer (sdnagent and its dependencies). This change builds a complete eden-sdn VM image—including bootloader, kernel, containerd, etc.—and packages it directly into the container, similar to how EVE images are handled in lfedge/eve. This significantly speeds up the eden-sdn setup process by eliminating the need to rebuild the VM image during each `eden setup`. Additionally, the VM image now uses legacy BIOS boot instead of UEFI, which is sufficient for eden-sdn and simplifies the boot process. Finally, eden-sdn now follows its own semantic versioning, independent of eden. Its version is manually defined in `sdn/VERSION`, ensuring that eden-sdn is not unnecessarily rebuilt and published with a new image tag when unrelated eden components change. These are initial steps towards integrating eden-sdn into eden tests and github workflows. Signed-off-by: Milan Lenco <[email protected]>
milan-zededa
force-pushed
the
sdn-vm-image
branch
from
2c982e2 to
1636aa1
Compare
|
OK, Apache Yetus is happy now. |
|
@uncleDecart Checks completed and they are all green... |
I see you're pressuring me into merging this :D, fair enough, LGTM |
Better merge my PRs, KGB knows where you live comrade! |
Previously, the
lfedge/eden-sdncontainer included only the SDN "service" layer (sdnagentand its dependencies). This change builds a complete eden-sdn VM image -- including bootloader, kernel, containerd, etc. -- and packages it directly into the container, similar to how EVE images are handled inlfedge/eve.This significantly speeds up the
eden-sdnsetup process by eliminating the need to rebuild the VM image during eacheden setup.Additionally, the VM image now uses legacy BIOS boot instead of UEFI, which is perfectly sufficient for
eden-sdnand simplifies the boot process.Finally,
eden-sdnnow follows its own semantic versioning, independent of eden. Its version is manually defined insdn/VERSION, ensuring thateden-sdnis not unnecessarily rebuilt and published with a new image tag when unrelated eden components change.These are initial steps towards integrating
eden-sdninto eden tests and github workflows.