Quadrature API changes #4076
Merged
Quadrature API changes #4076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job Coverage, step Generate coverage on 617e7d9 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
jwpeterson
approved these changes
Feb 12, 2025
roystgnr
force-pushed
the
quadrature_api_changes
branch
from
77b5807 to
16417d3
Compare
These have been deprecated and ignored for a while, and this refactor is a good time to get rid of them for good.
We don't need this in libMesh itself, but MOOSE has a subclass of QBase and other codes might as well.
If we have a POLYGON1 or a future POLYHEDRON1 or anything else where the quadrature rule will need to depend on more than just a single element type, we'll need to initialize quadrature objects with the physical element.
With two ways to be initialized (with a physical element vs with just an element type), this simplifies a lot of "initialize one quadrature rule based on another rule" code elsewhere in the quadrature rules.
We can't deprecate this overload entirely, because there are use cases where we e.g. want a 1D quadrature rule without wanting to create an actual Edge2 to pass to the const Elem& overload, but we don't want application codes to manually init() a quadrature rule in a way that will break on general polygons and polyhedra. So we'll provide a way to say "no, we're not screwing up, we know we're specifying an ElemType for which you don't need a full Elem".
roystgnr
force-pushed
the
quadrature_api_changes
branch
from
fd6779e to
617e7d9
Compare
roystgnr
added a commit
to roystgnr/libmesh
that referenced
this pull request
Feb 28, 2025
This was supposed to be part of libMesh#4076 but I missed getting it in there somehow.
roystgnr
added a commit
to roystgnr/libmesh
that referenced
this pull request
Mar 1, 2025
This was supposed to be part of libMesh#4076 but I missed getting it in there somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This strips out just the quadrature-related changes that #4074 depends on, as per @jwpeterson 's request for easier testing and review.
A couple of those commits had Polygon code leak in; that should be fixed here via interactive rebases but it does mean that I'll need to do a little of the same work in #4074 afterward.