Conversation
galargh
commented
Aug 11, 2023
galargh
commented
Aug 11, 2023
galargh
commented
Aug 11, 2023
galargh
commented
Aug 11, 2023
Contributor
marten-seemann
left a comment
marten-seemann
left a comment
There was a problem hiding this comment.
Very nice work @galargh! Thank you!!
| id: remote | ||
| env: | ||
| GITHUB_TOKEN: ${{ github.token }} | ||
| run: gh api repos/$REPO/releases/latest --jq '.tag_name' | xargs -I{} echo "version={}" | tee -a $GITHUB_OUTPUT |
Contributor
There was a problem hiding this comment.
Have you considered using go list -m -versions github.com/libp2p/go-libp2p@latest?
Member
Author
There was a problem hiding this comment.
No, didn't know about this one. If you prefer, this should behave the same.
Suggested change
| run: gh api repos/$REPO/releases/latest --jq '.tag_name' | xargs -I{} echo "version={}" | tee -a $GITHUB_OUTPUT | |
| run: go list -m github.com/$REPO@latest | cut -d' ' -f2 | xargs -I{} echo "version={}" | tee -a $GITHUB_OUTPUT |
mxinden
reviewed
Aug 14, 2023
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Thank you Piotr! Ready to merge from my end.
| clean: | ||
| rm perf | ||
| rm .cache | ||
| rm v0.28 |
Member
There was a problem hiding this comment.
This is created when one runs go build .. That said, fine to remove it.
| git commit -m "chore: add go-libp2p@$REMOTE_VERSION to $DIR" | ||
| git push origin $BRANCH --force | ||
| gh pr create --title "chore: add go-libp2p@$REMOTE_VERSION to $DIR" --body "This PR adds go-libp2p@$REMOTE_VERSION to $DIR" --head $BRANCH --base $GITHUB_REF | ||
| gh workflow run perf.yml --ref $BRANCH |
Contributor
|
Sweet! What's needed to merge this? |
Member
codemaestro64
pushed a commit
to codemaestro64/test-plans
that referenced
this pull request
Oct 28, 2025
* feat: automate adding new go-libp2p versions to perf * fix: put add-new-impl-versions.yml on schedule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the process described here: libp2p/go-libp2p#2442 (comment)
Additionally:
Automatically created PR: #255
Automatically triggered perf run: https://github.com/libp2p/test-plans/actions/runs/5836370405