Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automate adding new go-libp2p versions to perf #256

Merged
merged 2 commits into from
Sep 2, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .github/workflows/add-new-impl-versions.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
name: Add new implementation versions

on:
push:
galargh marked this conversation as resolved.
Show resolved Hide resolved

defaults:
run:
shell: bash

permissions:
contents: write
pull-requests: write
actions: write

jobs:
go:
runs-on: ubuntu-latest
env:
DIR: perf/impl/go-libp2p
REPO: libp2p/go-libp2p
BRANCH: perf/go-libp2p
steps:
- name: Checkout test-plans
uses: actions/checkout@v3
- name: Configure git
run: |
git fetch $BRANCH && git checkout $BRANCH && git rebase $GITHUB_REF -X theirs || git checkout -b $BRANCH
git config --global user.email [email protected]
git config --global user.name $GITHUB_ACTOR
- id: go
uses: actions/setup-go@v3
with:
go-version: stable
- name: Get the latest version (local)
id: local
run: ls -d v* | sort -V | tail -n-1 | xargs -I{} echo "version={}" | tee -a $GITHUB_OUTPUT
working-directory: ${{ env.DIR }}
- name: Get the latest version (remote)
id: remote
env:
GITHUB_TOKEN: ${{ github.token }}
run: gh api repos/$REPO/releases/latest --jq '.tag_name' | xargs -I{} echo "version={}" | tee -a $GITHUB_OUTPUT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered using go list -m -versions github.com/libp2p/go-libp2p@latest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, didn't know about this one. If you prefer, this should behave the same.

Suggested change
run: gh api repos/$REPO/releases/latest --jq '.tag_name' | xargs -I{} echo "version={}" | tee -a $GITHUB_OUTPUT
run: go list -m github.com/$REPO@latest | cut -d' ' -f2 | xargs -I{} echo "version={}" | tee -a $GITHUB_OUTPUT

- name: Add the latest version
if: ${{ !startsWith(steps.remote.outputs.version, steps.local.outputs.version) }}
env:
LOCAL_VERSION: ${{ steps.local.outputs.version }}
REMOTE_VERSION: ${{ steps.remote.outputs.version }}
GO_VERSION: ${{ steps.go.outputs.go-version }}
GITHUB_TOKEN: ${{ github.token }}
run: |
majorMinorRemoteVersion=$(echo $REMOTE_VERSION | sed 's/\.[0-9]*$//')
majorMinorGoVersion=$(echo $GO_VERSION | sed 's/\.[0-9]*$//')
cp -r $LOCAL_VERSION $majorMinorRemoteVersion
cd $majorMinorRemoteVersion
sed -i "1s/$LOCAL_VERSION/$majorMinorRemoteVersion/g" go.mod
go mod tidy -go=$majorMinorGoVersion
go mod tidy
go get github.com/libp2p/go-libp2p@$REMOTE_VERSION
git add .
git commit -m "chore: add go-libp2p@$REMOTE_VERSION to $DIR"
git push origin $BRANCH --force
gh pr create --title "chore: add go-libp2p@$REMOTE_VERSION to $DIR" --body "This PR adds go-libp2p@$REMOTE_VERSION to $DIR" --head $BRANCH --base $GITHUB_REF
gh workflow run perf.yml --ref $BRANCH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

working-directory: ${{ env.DIR }}
1 change: 0 additions & 1 deletion perf/impl/go-libp2p/v0.28/.gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
perf
.cache
v0.28
galargh marked this conversation as resolved.
Show resolved Hide resolved
14 changes: 0 additions & 14 deletions perf/impl/go-libp2p/v0.28/Dockerfile
galargh marked this conversation as resolved.
Show resolved Hide resolved

This file was deleted.

3 changes: 1 addition & 2 deletions perf/impl/go-libp2p/v0.28/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@ GO_FILES := $(wildcard *.go)
all: perf

perf: $(GO_FILES)
docker run --rm --user "$(shell id -u):$(shell id -g)" -v "$(shell pwd)":/usr/src/myapp -w /usr/src/myapp -e GOCACHE=/usr/src/myapp/.cache golang:1.20 go build -o perf .
docker run --rm --user "$(shell id -u):$(shell id -g)" -v "$(shell pwd)":/usr/src/myapp -w /usr/src/myapp -e GOCACHE=/usr/src/myapp/.cache golang:$(shell awk '/^go [0-9]+(\.[0-9]+)?$$/ {print $$2}' go.mod) go build -o perf .
galargh marked this conversation as resolved.
Show resolved Hide resolved

clean:
rm perf
rm .cache
rm v0.28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is created when one runs go build .. That said, fine to remove it.


.PHONY: all clean