multi: rename experimental endorsement signal to accountable #10367
Conversation
Summary of ChangesHello @elnosh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a comprehensive renaming of the experimental Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly renames the experimental endorsement feature to accountable to align with the latest bLIP-4 proposal. The changes are applied consistently across the entire codebase, including configuration options, feature flags, internal logic, and tests. I've also noted the removal of the time-based experiment logic for this feature, which is a correct interpretation of the updated proposal. The code quality is high, and I have no further comments. The changes look good to merge.
carlaKC
left a comment
carlaKC
left a comment
There was a problem hiding this comment.
Thanks for bringing this up to date!
Linter is unhappy in a few places because renames push over the 80 char limit, and needs an entry in release notes, otherwise LGTM!
| SetNodeAnn: {}, // N | ||
| }, | ||
| lnwire.ExperimentalEndorsementOptional: { | ||
| lnwire.ExperimentalAccountabilityOptional: { |
There was a problem hiding this comment.
nit: one mention of endorsement left in comment.
rpcserver.go
Outdated
| return clock.NewDefaultClock().Now().Before( | ||
| AccountabilityExperimentEnd, | ||
| ) | ||
| return !s.cfg.ProtocolOptions.NoExperimentalAccountability() |
There was a problem hiding this comment.
linter unhappy: perhaps NoExpAccountability to shorten line
elnosh
force-pushed
the
rename-endorsement-accountable
branch
from
ade4917 to
5c68675
Compare
Renames the endorsement signal to accountable to match the latest proposal lightning/blips#67
In the previous iteration with endorsement signaling, the recommendation was for the sender to set it to 1 and that could have had privacy concerns when first deploying given that the default was to downgrade the signal to 0. In the latest proposal the recommended default for both sending and forwarding nodes is to set `accountable` to 0. As a result, the dates have been removed given that there are no privacy risks associated with relaying the signal with zero values.
elnosh
force-pushed
the
rename-endorsement-accountable
branch
from
5c68675 to
19f31ec
Compare
2 participants
This PR renames bLIP4's experimental
endorsementsignal toaccountableto match the latest proposal in lightning/blips#67