ISSUE-414 add test to verify next valid alarm is selected when earlier one already expired

[vttranlina]

No description provided.

[chibenwa]

While the test is useful, it do not give enough garanties.

Can we write test in other part of the code, eg in AlarmTriggerService ?

We can clearly see that planning of the next occurrence happens only for recurring events. And not for events with several VALARMS.

Also this logic is flowed:

Optional<AlarmInstant> computeNextAlarmInstant(Calendar calendar, Username username);

If run falst enough we double trigger alarms which is a reported bug.

Evolution suggestion:

Optional<AlarmInstant> computeNextAlarmInstant(Calendar calendar, Username username, AlarmInstant latestTriggerAlarm);

with the constraint of the returned AlarmInstant to be strictly greater.

Can thos 2 changes be added here please?