Update pre-check to prevent duplicate xDS client start. #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohhyang
reviewed
Oct 15, 2025
| ## [Unreleased] | ||
|
|
||
| ## [29.80.1] - 2025-10-15 | ||
| - Update pre-check to prevent duplicate xDS client start |
Contributor
There was a problem hiding this comment.
"prevent" should be "log", right? since it's ok to call start again.
Collaborator
Author
There was a problem hiding this comment.
My thought is that returning early on duplicate calls can act as a preventive measure., then it could be a prevent scenario. But, yes, log is more accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the pre-check checks for various issues for indis connection. The start() method indeed can be called multiple times for valid reasons, since app owners are allowed to explicitly call d2Client.start and wait for the callback to ensure a d2 client is started before using it. We should change the throw to an info log and just return (no-op) in that case.