Skip to content

Update pre-check to prevent duplicate xDS client start. #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update pre-check to prevent duplicate xDS client start. #1113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ and what APIs have changed, if applicable.

## [Unreleased]

## [29.80.1] - 2025-10-15
- Update pre-check to prevent duplicate xDS client start
Copy link
Contributor

@bohhyang bohhyang Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"prevent" should be "log", right? since it's ok to call start again.

Copy link
Collaborator Author

@brycezhongqing brycezhongqing Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thought is that returning early on duplicate calls can act as a preventive measure., then it could be a prevent scenario. But, yes, log is more accurate.


## [29.80.0] - 2025-10-10
- Update methodLevelProperties in ServiceProperties constructor

Expand Down Expand Up @@ -5918,7 +5921,8 @@ patch operations can re-use these classes for generating patch messages.

## [0.14.1]

[Unreleased]: https://github.com/linkedin/rest.li/compare/v29.80.0...master
[Unreleased]: https://github.com/linkedin/rest.li/compare/v29.80.1...master
[29.80.1]: https://github.com/linkedin/rest.li/compare/v29.80.0...v29.80.1
[29.80.0]: https://github.com/linkedin/rest.li/compare/v29.79.1...v29.80.0
[29.79.1]: https://github.com/linkedin/rest.li/compare/v29.79.0...v29.79.1
[29.79.0]: https://github.com/linkedin/rest.li/compare/v29.78.0...v29.79.0
Expand Down
3 changes: 2 additions & 1 deletion d2/src/main/java/com/linkedin/d2/xds/XdsClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,8 @@ public void start()
{
if (!_started.compareAndSet(false, true))
{
throw new IllegalStateException("Cannot start XdsClient more than once");
_log.info("XdsClientImpl.start() called multiple times, ignoring subsequent calls.");
return;
}

_xdsClientJmx.setXdsClient(this);
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version=29.80.0
version=29.80.1
group=com.linkedin.pegasus
org.gradle.configureondemand=true
org.gradle.parallel=true
Expand Down
Loading