Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added charts for spring-boot-chaos experiment #543

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

cazeaux
Copy link

@cazeaux cazeaux commented Apr 29, 2022

This is the charts for the chaos spring boot experiments. It relates to the issue litmuschaos/litmus#3538 and PR litmuschaos/litmus-go#511

Signed-off-by: Stéphane Cazeaux [email protected]

@neelanjan00 neelanjan00 added the enhancement New feature or request label May 25, 2022

# Chaos Monkey Spring Boot configuration
# Level determines at which frequency the assault happens on the application. For a value N, the assaults happens every N requests
- name: CM_LEVEL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we only add the mandatory variables here in the engine while the optional variables (which can be supplemented with a default value in the experiments.yaml file)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, these variables are mandatory to be provided for the chaos by the user so they can be added to engine.yaml

      # Comma separated list of watched Java services. Ex: com.example.application.controller.HelloController.sayHelle
      - name: CM_WATCHED_CUSTOM_SERVICES
        value: ''

      # Comma separated list of watchers. Possible values: controller, restController, service, repository, component, restTemplate, webClient, actuatorHealth
      - name: CM_WATCHERS
        value: 'restController'

These two can also be provided in engine.yaml, not sure if the user would require to change them frequently

# Level determines at which frequency the assault happens on the application. For a value N, the assaults happens every N requests
      - name: CM_LEVEL
        value: '1'

      # Whether the level should be used as a deterministic value (attack every x requests) or a chance (on average, 1 in x requests will be attacked)
      - name: CM_DETERMINISTIC
        value: 'true'

If none of these are, we can continue with the current engine.yaml config.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now understand better what "mandatory" means here. Actually, what we want to see in the engine.yaml corresponds to the parameter that we want the user to pay attention at and change.
I will make a new proposition, but indeed I think that some parameters need to be added (such as all *_ACTIVE)

charts/spring-boot/spring-boot-chaos/experiment.yaml Outdated Show resolved Hide resolved
charts/spring-boot/experiments.yaml Outdated Show resolved Hide resolved
@cazeaux cazeaux force-pushed the spring-boot-chaos branch from 65ee96a to 6a1dc1c Compare June 7, 2022 10:23
charts/spring-boot/experiments.yaml Show resolved Hide resolved
charts/spring-boot/experiments.yaml Outdated Show resolved Hide resolved
charts/spring-boot/spring-boot-chaos/experiment.yaml Outdated Show resolved Hide resolved
@cazeaux cazeaux force-pushed the spring-boot-chaos branch 2 times, most recently from 52e6abb to 557bb97 Compare June 22, 2022 07:15
@avaakash avaakash requested a review from neelanjan00 June 28, 2022 15:15
Comment on lines +29 to +30
- name: Spring Boot
url: https://spring.io/projects/spring-boot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add the docs link here?

@mbecca
Copy link

mbecca commented Sep 26, 2022

Hi, any news for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants