-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added charts for spring-boot-chaos experiment #543
base: master
Are you sure you want to change the base?
Conversation
|
||
# Chaos Monkey Spring Boot configuration | ||
# Level determines at which frequency the assault happens on the application. For a value N, the assaults happens every N requests | ||
- name: CM_LEVEL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we only add the mandatory variables here in the engine while the optional variables (which can be supplemented with a default value in the experiments.yaml
file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, these variables are mandatory to be provided for the chaos by the user so they can be added to engine.yaml
# Comma separated list of watched Java services. Ex: com.example.application.controller.HelloController.sayHelle
- name: CM_WATCHED_CUSTOM_SERVICES
value: ''
# Comma separated list of watchers. Possible values: controller, restController, service, repository, component, restTemplate, webClient, actuatorHealth
- name: CM_WATCHERS
value: 'restController'
These two can also be provided in engine.yaml, not sure if the user would require to change them frequently
# Level determines at which frequency the assault happens on the application. For a value N, the assaults happens every N requests
- name: CM_LEVEL
value: '1'
# Whether the level should be used as a deterministic value (attack every x requests) or a chance (on average, 1 in x requests will be attacked)
- name: CM_DETERMINISTIC
value: 'true'
If none of these are, we can continue with the current engine.yaml config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now understand better what "mandatory" means here. Actually, what we want to see in the engine.yaml corresponds to the parameter that we want the user to pay attention at and change.
I will make a new proposition, but indeed I think that some parameters need to be added (such as all *_ACTIVE)
65ee96a
to
6a1dc1c
Compare
52e6abb
to
557bb97
Compare
557bb97
to
70f6a4a
Compare
- name: Spring Boot | ||
url: https://spring.io/projects/spring-boot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add the docs link here?
Hi, any news for this PR? |
Signed-off-by: Stéphane Cazeaux <[email protected]>
Co-authored-by: Neelanjan Manna <[email protected]> Signed-off-by: Stéphane Cazeaux <[email protected]>
Co-authored-by: Neelanjan Manna <[email protected]> Signed-off-by: Stéphane Cazeaux <[email protected]>
Signed-off-by: Stephane Cazeaux <[email protected]>
Signed-off-by: Stephane Cazeaux <[email protected]>
…ue with yaml parsing. Signed-off-by: Stephane Cazeaux <[email protected]>
Signed-off-by: Stephane Cazeaux <[email protected]>
Co-authored-by: Akash Shrivastava <[email protected]> Signed-off-by: Stéphane Cazeaux <[email protected]>
Co-authored-by: Akash Shrivastava <[email protected]> Signed-off-by: Stéphane Cazeaux <[email protected]>
80944c2
to
47e2664
Compare
398ace7
to
47e2664
Compare
This is the charts for the chaos spring boot experiments. It relates to the issue litmuschaos/litmus#3538 and PR litmuschaos/litmus-go#511
Signed-off-by: Stéphane Cazeaux [email protected]