Added spatial index to OverlayNG PolygonBuilder.placeFreeHoles #1173
+9
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a spatial filter to the polygonbuilder that is part of overlayng. This was already suggested in a comment present in the previous version.
I did some performance measurements too, to see how much time it saves. For the tests, I computed the difference between two MultiPolygons, one being a region and the other being lakes and rivers inside that region, both taken from OpenStreetMaps. Here are the performance results:
*The data set for France is too big to upload, it's available upon request.
For the measurements, I took the average of five runs. I also checked that the areas of the resulting shapes match exactly in both runs.