Skip to content

Added spatial index to OverlayNG PolygonBuilder.placeFreeHoles #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arriopolis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added spatial index to OverlayNG PolygonBuilder.placeFreeHoles #1173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions modules/core/src/main/java/org/locationtech/jts/operation/overlayng/PolygonBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
import org.locationtech.jts.geom.Polygon;
import org.locationtech.jts.geom.TopologyException;
import org.locationtech.jts.util.Assert;
import org.locationtech.jts.index.SpatialIndex;
import org.locationtech.jts.index.hprtree.HPRtree;

class PolygonBuilder {

Expand Down Expand Up @@ -175,11 +177,16 @@ private static void assignHoles(OverlayEdgeRing shell, List<OverlayEdgeRing> edg
*/
private void placeFreeHoles(List<OverlayEdgeRing> shellList, List<OverlayEdgeRing> freeHoleList)
{
// TODO: use a spatial index to improve performance
SpatialIndex index = new HPRtree();
for (OverlayEdgeRing shell : shellList) {
index.insert(shell.getRing().getEnvelopeInternal(), shell);
}

for (OverlayEdgeRing hole : freeHoleList ) {
// only place this hole if it doesn't yet have a shell
if (hole.getShell() == null) {
OverlayEdgeRing shell = hole.findEdgeRingContaining(shellList);
List<OverlayEdgeRing> shellListOverlaps = index.query(hole.getRing().getEnvelopeInternal());
OverlayEdgeRing shell = hole.findEdgeRingContaining(shellListOverlaps);
// only when building a polygon-valid result
if (isEnforcePolygonal && shell == null) {
throw new TopologyException("unable to assign free hole to a shell", hole.getCoordinate());
Expand Down