-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hw,mbx] Sync mailbox from integrated_dev to master #24437
Conversation
7bd9358
to
acb3ff8
Compare
90bb902
to
c31c8b7
Compare
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Neeraj Upasani <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Minor fixes to support use of vcs as an alternative. Signed-off-by: Adrian Lees <[email protected]>
Clearing of Abort condition resets both inbound and outbound traffic, clears down the count of outstanding requests and suppresses any subsequent core-side TL-UL read responses. Since the Abort request clears Ready, keep the Read Data register zeroed until the abort is acknowledged. Signed-off-by: Adrian Lees <[email protected]>
Abort acknowledgement is of the highest priority, permitting its use as a FW-driven reset mechanism even if there was no explicit SoC-side Abort request. Signed-off-by: Adrian Lees <[email protected]>
Abort clearing/FW-initiated reset must clear the count of outstanding requests to suppress delayed responses from propagating into the mailbox logic. Signed-off-by: Adrian Lees <[email protected]>
This ensures that all existing tests are mapped to a testpoint. Signed-off-by: Andreas Kurth <[email protected]>
Instead of only using the next state signal of the FSM, we also take into account the current state, to compute the transition edge into the Read and Abort state, that generates the event for the IRQ primitive. Closes lowRISC/opentitan-integrated#714 Signed-off-by: Robert Schilling <[email protected]>
Modify documentation to specify that the mailbox limit addresses are inclusive and indicate the final usable DWORD location. Update DIF address checks accordingly. Signed-off-by: Adrian Lees <[email protected]>
Migrate code from smoke sequence into base sequence to form the basis of a test suite include stress sequences. Minor corrections. No significant impact upon current smoke sequence. Signed-off-by: Adrian Lees <[email protected]>
Introduce constrained, randomized sequence item that describes a request and response communication. Multiple back-to-back transactions between IP block resets. Multiple iterations, separated by IP block resets. Signed-off-by: Adrian Lees <[email protected]>
Simple stress test runs more iterations of more transactions. To be extended. Signed-off-by: Adrian Lees <[email protected]>
Generate SoC-side Aborts, Core-side Errors and Core-Side FW-initiated resets (Abort acknowledgements). Support interrupt-driven or CSR-driven operation. Signed-off-by: Adrian Lees <[email protected]> Co-authored-by: Harry Callahan <[email protected]>
Randomization of TL-UL access and response timings within stress sequence(s). Introduce 'zero delays' stress sequence for throughput testing and exercising back-pressuring logic. Signed-off-by: Adrian Lees <[email protected]>
Signed-off-by: Harry Callahan <[email protected]>
Signed-off-by: Harry Callahan <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
The former is a test specifically written for Mailbox (and it already exists) while the latter is a generic test that combines tests specifically written for Mailbox. Both should be part of V2 (in contrast to the generic `stress_all_with_rand_reset`, which is part of V3). Signed-off-by: Andreas Kurth <[email protected]>
Signed-off-by: Andreas Kurth <[email protected]>
Signed-off-by: Andreas Kurth <[email protected]>
A mailbox con either be a PCIe mailbox or a FW mailbox. In case of the PCIe setting, the SOC reagisters 0x0 and 0x4 implement the capability header functionality, but this is done outside of the mbx RTL. PCIe mailboxes do not use the SOC_INTR_DATA/ADDR registers. FW-based mailboxes on the other hand only use the SOC_INTR_DATA/ADDR registers but no capability headers. Previously, it was decided to alias both registers as they are used orthogonally. However, this deceission was revised. This PR moves the SOC_INTR_DATA/ADDR registers to the end of the SOC register interface to not alias with any capability header registers for PCIe mailboxes Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
c31c8b7
to
dace55d
Compare
I've just been looking at this today, and it seems that some commits have been squashed together as part of the migration. For example, 0a2ca18 appears to have been squashed into 978e5c5 to create 382a08a, as well as some other changes at the same time. Was this intentional? It's making the reviewing process tricky, as it's harder to see any new or unintended changes made as part of the migration. I can probably power through if it would be too difficult to go backwards now, but it's going to take me longer to work through.
Quite a few of the 'lost' commits appear to have been squashed into their neighbors. |
That is strange. No that is not intentional. Let, me try that again and see if I get a different list of commits. |
@hcallahan-lowrisc Not sure what happened here. They are indeed lost and squashed. I re-created the PR with all commits in #24687 |
No description provided.