[kmac, rtl/dv/sw] Remove unused error code #25035
Draft
+7
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ErrShadowRegUpdate` code is never used in the RTL. Instead, according to the documentation, on a shadow register update error, a recoverable alert shall be triggered - this recoverable alert then is signaled in the STATUS register and not in the error code register. Hence, this commit removes this error code as well as the corresponding SW code (`kDifErrorShadowRegisterUpdate`). Signed-off-by: Pascal Nasahl <[email protected]>
vogelpi
reviewed
Nov 7, 2024
Comment on lines
-459
to
+466
| // Error Shadow register update | ||
| ErrShadowRegUpdate = 8'h C0, | ||
|
|
||
| // Error due to lc_escalation_en_i or fatal fault | ||
| ErrFatalError = 8'h C1, | ||
| ErrFatalError = 8'h C0, | ||
|
|
||
| // Error due to the counter integrity check failure inside MsgFifo.Packer | ||
| ErrPackerIntegrity = 8'h C2, | ||
| ErrPackerIntegrity = 8'h C1, | ||
|
|
||
| // Error due to the counter integrity check failure inside MsgFifo.Fifo | ||
| ErrMsgFifoIntegrity = 8'h C3 | ||
| ErrMsgFifoIntegrity = 8'h C2 |
There was a problem hiding this comment.
I think the "right" way to handle this would be just remove ErrShadowRegUpdate without modifying the other encodings. Because touching the other encodings would mean an change to the software interface: software compliant with A0/A1 would only be partially compatible. This would mean a version increment. We should avoid this at this point.
Maybe it we should just remove it now but add a note somewhere (in an issue?) to edit also the other encodings next time we do an interface change anyway?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ErrShadowRegUpdatecode is never used in the RTL. Instead, according to the documentation, on a shadow register update error, a recoverable alert shall be triggered - this recoverable alert then is signaled in the STATUS register and not in the error code register.Hence, this commit removes this error code as well as the corresponding SW code (
kDifErrorShadowRegisterUpdate).