Cherry-pick to earlgrey_1.0.0: [dice] Refactor some dice related constants and APIs #25047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
It'll be invoked by several modules, so move it to base:util library for code reuse. Signed-off-by: Tommy Chiu <[email protected]> (cherry picked from commit c5a98c9)
Both X509 and CWT DICE implementations need these definitions. Move it out from the original source file for code reuse. Signed-off-by: Tommy Chiu <[email protected]> (cherry picked from commit aebd611)
The autogen source from templates needs some more APIs to utilize the Cbor structure, including - calculate the size of a given cbor argument - add a bstr/tstr header with size, and rewind the cursor - copy the raw data from input pointer to the CborOut buffer Signed-off-by: Tommy Chiu <[email protected]> (cherry picked from commit c735b28)
github-actions
bot
requested review from
engdoreis
and removed request for
a team
timothytrippel
requested review from
timothytrippel and
tommychiu-github
and removed request for
engdoreis
timothytrippel
approved these changes
Nov 8, 2024
engdoreis
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic cherry-pick of #25023 to branch
earlgrey_1.0.0.