Skip to content

Conversation

@marlonnienaber
Copy link
Contributor

@marlonnienaber marlonnienaber commented Jul 17, 2025

Motivation and Context

This PR updates Artemis to Angular 20 and fixes broken client tests that resulted from the update.

Steps for Testing

Please choose one of the "feature clusters" listed below that was not yet tested and go through the most important screens/verify the most important functionality. Please check the feature cluster after your test.

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Communication
  • Lectures
  • Courses
  • User Management
  • Programming Exercises
  • Quiz Exercises
  • Text Exercises
  • File Upload Exercises
  • Modeling Exercises
  • Plagiarism
  • Exam
  • Communication

Summary by CodeRabbit

  • New Features

    • Upgraded Angular framework and related libraries to version 20.x for improved stability and new capabilities.
    • Updated multiple third-party dependencies, including FontAwesome, Sentry, ngx-datatable, and ngx-charts, for enhanced compatibility and security.
  • Bug Fixes

    • Adjusted type declarations and property resets in components for more robust state handling.
    • Improved test assertions and configurations by integrating the actual FontAwesome icon component and using Angular testing utilities.
  • Refactor

    • Replaced deprecated Angular testing methods and mocks with updated practices, including switching from mocked to real icon components.
    • Enhanced type annotations for clearer code and maintainability.
    • Unified asynchronous test setups with a new helper function for consistent component initialization.
    • Modernized dependency injection by replacing constructor injection with Angular's inject() function in calendar-related components.
    • Updated test invocation styles for injection context and improved test element querying methods.
  • Chores

    • Removed obsolete patch files related to graph components.
    • Updated dependency overrides for build tools and libraries to align with new versions.

@github-project-automation github-project-automation bot moved this to Work In Progress in Artemis Development Jul 17, 2025
@github-actions github-actions bot added tests client Pull requests that update TypeScript code. (Added Automatically!) assessment Pull requests that affect the corresponding module atlas Pull requests that affect the corresponding module communication Pull requests that affect the corresponding module core Pull requests that affect the corresponding module exam Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module fileupload Pull requests that affect the corresponding module iris Pull requests that affect the corresponding module lecture Pull requests that affect the corresponding module labels Jul 17, 2025
Copy link
Contributor

@Predixx Predixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested file upload exercise. Worked for me as expected.

@helios-aet helios-aet bot temporarily deployed to artemis-test3.artemis.cit.tum.de July 18, 2025 09:03 Inactive
Copy link
Contributor

@jfr2102 jfr2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested creating and participating in a programming exercise via online code editor on ts1. Works as expected 👍

Copy link
Contributor

@tobias-lippert tobias-lippert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

Copy link
Contributor

@jonas-de jonas-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested creating and editing a quiz exercise with multiple question types as instructor and participation and practice as student (TS3). Everything works as expected

Copy link
Contributor

@badkeyy badkeyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested communication on TS1. Everything works as expected. Code lgtm.

Copy link
Contributor

@MoritzSpengler MoritzSpengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Quiz and Text exercises on TS3 as Instructor and Student. Everything works as expected.

Copy link
Contributor

@Jan-Thurner Jan-Thurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Modelling exercises on TS3. Works as expected.

@helios-aet helios-aet bot temporarily deployed to artemis-test2.artemis.cit.tum.de July 18, 2025 10:43 Inactive
Copy link
Contributor

@LeZhen1105 LeZhen1105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested User Management worked as expected.

@helios-aet helios-aet bot temporarily deployed to artemis-test5.artemis.cit.tum.de July 18, 2025 11:51 Inactive
@helios-aet helios-aet bot temporarily deployed to artemis-test3.artemis.cit.tum.de July 18, 2025 12:14 Inactive
Copy link
Contributor

@eylulnc eylulnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Communication tested on TS2. works as expected

Copy link
Contributor

@HawKhiem HawKhiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on TS3. I have tested the following:

  1. Communication:
    ❌ When delete a message, then quickly undo the deletion, switch to another channel then come back, I noticed that the message is still deleted
Screen.Recording.2025-07-18.145103.mp4

✅ Everything else like pin message, edit message, save post or forward post, creating channels, direct chat, group chat, etc. works fine

  1. Lectures
    ✅ Everything works as expected from creating lectures, add attachment, units, sending to Iris, hiding pages and downloading

  2. Plagiarism
    ✅ Everything works as expected

Copy link
Contributor

@cremertim cremertim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested commuunication features, did not run into any error. Did not retest previously mentioned error, but i suspect it is not related to this PR

@eylulnc
Copy link
Contributor

eylulnc commented Jul 18, 2025

I tested on TS3. I have tested the following:

  1. Communication:
    ❌ When delete a message, then quickly undo the deletion, switch to another channel then come back, I noticed that the message is still deleted

Screen.Recording.2025-07-18.145103.mp4
✅ Everything else like pin message, edit message, save post or forward post, creating channels, direct chat, group chat, etc. works fine

  1. Lectures
    ✅ Everything works as expected from creating lectures, add attachment, units, sending to Iris, hiding pages and downloading
  2. Plagiarism
    ✅ Everything works as expected

Agreed with Tim, @HawKhiem can you create a issue for this one?

@helios-aet helios-aet bot temporarily deployed to artemis-test1.artemis.cit.tum.de July 18, 2025 15:39 Inactive
Copy link

@SindiBuklaji SindiBuklaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Exam on Ts1. Everything works as expected 👍

@krusche krusche changed the title General: Update to Angular 20 Development: Update to Angular 20 Jul 18, 2025
@ls1intum ls1intum deleted a comment from github-actions bot Jul 18, 2025
@helios-aet helios-aet bot temporarily deployed to artemis-test2.artemis.cit.tum.de July 18, 2025 16:34 Inactive
@HawKhiem
Copy link
Contributor

I tested on TS3. I have tested the following:

  1. Communication:
    ❌ When delete a message, then quickly undo the deletion, switch to another channel then come back, I noticed that the message is still deleted

Screen.Recording.2025-07-18.145103.mp4
✅ Everything else like pin message, edit message, save post or forward post, creating channels, direct chat, group chat, etc. works fine

  1. Lectures
    ✅ Everything works as expected from creating lectures, add attachment, units, sending to Iris, hiding pages and downloading
  2. Plagiarism
    ✅ Everything works as expected

Agreed with Tim, @HawKhiem can you create a issue for this one?

Yes, I will do it right away

@helios-aet helios-aet bot temporarily deployed to artemis-test3.artemis.cit.tum.de July 18, 2025 16:40 Inactive
Copy link
Contributor Author

@marlonnienaber marlonnienaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested course and user management locally

Copy link
Contributor

@florian-glombik florian-glombik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the user management on ts3

  • Added users to different user groups (student, tutor, editor, instructor)
  • Created a new user (added and removed user groups)
  • Search for user worked
  • User can be deactivated / activated
  • Can add and remove organization
  • View / Edit works
  • Filter in user overview works
  • Import dialog opens (did not actually import users)
  • Deleting user works

@krusche krusche merged commit 6c5ee3d into develop Jul 18, 2025
93 of 98 checks passed
@krusche krusche deleted the chore/update-angular20 branch July 18, 2025 19:56
@github-project-automation github-project-automation bot moved this from Work In Progress to Merged in Artemis Development Jul 18, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Communication Webclient Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assessment Pull requests that affect the corresponding module atlas Pull requests that affect the corresponding module client Pull requests that update TypeScript code. (Added Automatically!) communication Pull requests that affect the corresponding module core Pull requests that affect the corresponding module exam Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module fileupload Pull requests that affect the corresponding module iris Pull requests that affect the corresponding module lecture Pull requests that affect the corresponding module modeling Pull requests that affect the corresponding module plagiarism Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module quiz Pull requests that affect the corresponding module ready for review tests text Pull requests that affect the corresponding module tutorialgroup Pull requests that affect the corresponding module

Projects

Archived in project
Status: Done

Development

Successfully merging this pull request may close these issues.