-
Notifications
You must be signed in to change notification settings - Fork 350
Development: Update to Angular 20
#11168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Predixx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested file upload exercise. Worked for me as expected.
jfr2102
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested creating and participating in a programming exercise via online code editor on ts1. Works as expected 👍
tobias-lippert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code
...assessment/manage/grading-system/grading-key-overview/grading-key-overview.component.spec.ts
Show resolved
Hide resolved
...ctions-assessment-layout/structured-grading-instructions-assessment-layout.component.spec.ts
Show resolved
Hide resolved
src/main/webapp/app/core/course/overview/course-overview/course-overview.component.spec.ts
Show resolved
Hide resolved
jonas-de
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested creating and editing a quiz exercise with multiple question types as instructor and participation and practice as student (TS3). Everything works as expected
badkeyy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested communication on TS1. Everything works as expected. Code lgtm.
MoritzSpengler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Quiz and Text exercises on TS3 as Instructor and Student. Everything works as expected.
Jan-Thurner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Modelling exercises on TS3. Works as expected.
LeZhen1105
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested User Management worked as expected.
eylulnc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Communication tested on TS2. works as expected
HawKhiem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested on TS3. I have tested the following:
- Communication:
❌ When delete a message, then quickly undo the deletion, switch to another channel then come back, I noticed that the message is still deleted
Screen.Recording.2025-07-18.145103.mp4
✅ Everything else like pin message, edit message, save post or forward post, creating channels, direct chat, group chat, etc. works fine
-
Lectures
✅ Everything works as expected from creating lectures, add attachment, units, sending to Iris, hiding pages and downloading -
Plagiarism
✅ Everything works as expected
cremertim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also tested commuunication features, did not run into any error. Did not retest previously mentioned error, but i suspect it is not related to this PR
Agreed with Tim, @HawKhiem can you create a issue for this one? |
SindiBuklaji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Exam on Ts1. Everything works as expected 👍
General: Update to Angular 20Development: Update to Angular 20
Yes, I will do it right away |
marlonnienaber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested course and user management locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the user management on ts3
- Added users to different user groups (student, tutor, editor, instructor)
- Created a new user (added and removed user groups)
- Search for user worked
- User can be deactivated / activated
- Can add and remove organization
- View / Edit works
- Filter in user overview works
- Import dialog opens (did not actually import users)
- Deleting user works
Motivation and Context
This PR updates Artemis to Angular 20 and fixes broken client tests that resulted from the update.
Steps for Testing
Please choose one of the "feature clusters" listed below that was not yet tested and go through the most important screens/verify the most important functionality. Please check the feature cluster after your test.
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Code Review
Manual Tests
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Chores