Skip to content

Default delete & dataset creation fix #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2025
Merged

Default delete & dataset creation fix #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
144710c
minor fixes
JSabadin Jul 7, 2025
9a1db68
don't break the default behaviour
JSabadin Jul 8, 2025
2065304
posix export paths
JSabadin Jul 8, 2025
26e9a7e
added test
kozlov721 Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion luxonis_ml/data/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ def inspect(
bucket_storage: BucketStorage = bucket_option,
):
"""Inspects images and annotations in a dataset."""

check_exists(name, bucket_storage)
if deterministic:
np.random.seed(42)
random.seed(42)
Expand Down
9 changes: 7 additions & 2 deletions luxonis_ml/data/datasets/luxonis_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,6 +874,11 @@ def delete_dataset(
@param delete_local: Whether to delete the dataset from local
storage.
"""
if not (delete_remote or delete_local):
raise ValueError(
"Must set delete_remote=True and/or delete_local=True when calling delete_dataset()"
)

if not self.is_remote and delete_local:
logger.info(
f"Deleting local dataset '{self.dataset_name}' from local storage"
Expand Down Expand Up @@ -1502,7 +1507,7 @@ def _dump_annotations(
Path(
data_path.name,
str(image_indices[file]) + file.suffix,
)
).as_posix()
),
"task_name": task_name,
}
Expand All @@ -1515,7 +1520,7 @@ def _dump_annotations(
Path(
data_path.name,
str(image_indices[file]) + file.suffix,
)
).as_posix()
),
"task_name": task_name,
"annotation": {
Expand Down
3 changes: 3 additions & 0 deletions tests/test_data/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,9 @@ def generator() -> DatasetIterator:
with pytest.raises(ValueError, match="Must provide either"):
dataset.set_skeletons()

with pytest.raises(ValueError, match="Must set delete_remote"):
dataset.delete_dataset()


@pytest.mark.dependency(name="test_dataset[BucketStorage.LOCAL]")
def test_loader_iterator(storage_url: str, tempdir: Path):
Expand Down
4 changes: 2 additions & 2 deletions tests/test_data/test_parsers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def test_dir_parser(
_, ann = next(iter(loader))
task_types = {get_task_type(task) for task in ann}
assert task_types == expected_task_types
dataset.delete_dataset()
dataset.delete_dataset(delete_local=True)


@pytest.mark.parametrize(
Expand Down Expand Up @@ -215,4 +215,4 @@ def test_dir_parser_explicit_type(
_, ann = next(iter(loader))
task_types = {get_task_type(task) for task in ann}
assert task_types == expected_task_types
dataset.delete_dataset()
dataset.delete_dataset(delete_local=True)
Loading