Skip to content

Conversation

@JSabadin
Copy link
Contributor

@JSabadin JSabadin commented Jul 7, 2025

Purpose

  • Raise an error if neither delete_remote nor delete_local is specified when calling LuxonisDataset.delete_dataset().
  • Prevent unintended dataset creation when inspecting a non-existent dataset.
  • Fix export paths so they use POSIX-style single slashes.

Specification

None / not applicable

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

@JSabadin JSabadin requested a review from a team as a code owner July 7, 2025 11:43
@JSabadin JSabadin requested review from conorsim, klemen1999, kozlov721 and tersekmatija and removed request for a team July 7, 2025 11:43
@github-actions github-actions bot added fix Fixing a bug data Changes affecting luxonis_ml.data subpackage CLI Changes affecting the CLI labels Jul 7, 2025
@JSabadin JSabadin requested a review from klemen1999 July 8, 2025 08:39
@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.58%. Comparing base (6ab5a8d) to head (26e9a7e).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files         102      102           
  Lines        6118     6122    +4     
=======================================
+ Hits         5848     5852    +4     
  Misses        270      270           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JSabadin JSabadin merged commit 8efbb4d into main Jul 14, 2025
16 checks passed
@JSabadin JSabadin deleted the fix/minor-fixes branch July 14, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLI Changes affecting the CLI data Changes affecting luxonis_ml.data subpackage fix Fixing a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants