Add Polish localization #4582
Merged
Add Polish localization #4582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #4582 +/- ##
=======================================
Coverage 59.80% 59.80%
=======================================
Files 189 189
Lines 21218 21218
=======================================
Hits 12689 12689
Misses 8529 8529 |
Sources/MapboxNavigation/Resources/pl.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
Sources/MapboxNavigation/Resources/pl.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
holuss
requested changes
Jan 12, 2024
Sources/MapboxNavigation/Resources/pl.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
Sources/MapboxNavigation/Resources/pl.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
Sources/MapboxNavigation/Resources/pl.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
Sources/MapboxNavigation/Resources/pl.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
Sources/MapboxNavigation/Resources/pl.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
Sources/MapboxNavigation/Resources/pl.lproj/Localizable.stringsdict
Outdated
Show resolved
Hide resolved
azarovalex
commented
Jan 17, 2024
azarovalex
commented
Jan 17, 2024
azarovalex
commented
Jan 17, 2024
azarovalex
commented
Jan 17, 2024
azarovalex
commented
Jan 17, 2024
Sources/MapboxNavigation/Resources/pl.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
holuss
approved these changes
Jan 19, 2024
kried
approved these changes
Jan 19, 2024
| "ENABLE_PRECISE_LOCATION" = "Włącz dokładną lokalizację, aby nawigować"; | ||
|
|
||
| /* Title used for arrival */ | ||
| "END_OF_ROUTE_ARRIVED" = "Dotarłeś"; |
There was a problem hiding this comment.
I'm just a bit worried about using masculine forms in instructions. The feminine form would be Dotarłaś
E.g. Google shows the label with the gender-neutral form Jesteś na miejscu - 'You are here', avoiding the need to use the past form.
The Directions API already uses the same masculine form Dotarłeś
There was a problem hiding this comment.
Agree it's not perfect, let's align with what Directions API uses right now so that text and speech are the same.
azarovalex
added a commit
that referenced
this pull request
Jan 19, 2024
azarovalex
added a commit
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Polish translations to NavSDK UI.
Both Directions API and Mapbox Speech API already support Polish, our SDK will automatically use it if application locale is set to Polish.