-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Added additional description to Stagger Axis property #4241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I think if possible, the extra description should only apply to hexagonal maps, yes. It would be confusing on staggered isometric maps, since most people working on those aren't going to be consciously thinking about how they're functionally similar to staggered hexagonal maps xP Good idea adding this to the GUI rather than the documentation like I'd suggested. Edit, though maybe this should be an issue: It would be nice if the stagger axis were selectable in the New Map dialog when a staggered orientation is selected. As it is, anyone working with flat-topped hexagons has to create their new map and then go into the properties to change the axis every time, TIled doesn't save that they want stagger axis X since it's not in the dialog. A fuller section in the documentation also sounds good. Where would it go, though? The Introduction would be bogged down by it. Maybe it's time Maps got their own manual page :] I always miss the Introduction when looking for info on Maps because "Introduction" just doesn't sound like "[how to create/work with] Maps". Additional topics for such a page that would be too much for the Introduction: replacing tilesets, hex side length and how it relates to tile size (perhaps in the section on orientations), how to access the map properties 🙃, background color, layer data formats, chunk size... Some of these things are only explained in the format specs, which is not a place regular users should have to look. Even if they're not imortant to most users, they're still visible options in the editor, and that means some users will want more info on them than you can fit in a tooltip (and the tooltips currently have very little, if any, info). |
While a text description is fine, and easiest to implement, making things visual with images would be even better. Not sure how much extra time it would cost though.. |
The visual would be provided by the tile grid in the map, which changes immediately, which I think it clearer than any icon would be, especially since the tiles can also be there for context. |
Alright, now it changes depending on the map orientation. :-)
I'll look into adding this as part of this PR while I'm at it.
Yes, I think giving maps their own page is a good idea, and thanks for considering which other topics could be covered there!
Yeah, actually having buttons with clear pictures would be great for this, but sure it'll be a little more effort. And as @eishiya pointed out, I'm not sure it's worth it with the map view already providing direct feedback. If we keep using a "New Map" dialog, it would certainly be nice to add a preview or a visual choice though. Similar situation exists with the "New Tileset" dialog, which could use a preview marking the tiles on the tileset image based on the parameters. |
99183df
to
6fd7791
Compare
A staggered X axis leads to Flat-Topped hexes whereas a staggered Y axis leads to Pointy-Topped hexes. Since this setting also applies to maps using Isometric (Staggered) orientation, the property only uses the additional labels when the map is using Hexagonal orientation. To support this, the EnumProperty now allows changing its enum names after the editor has been created.
6fd7791
to
ebc619c
Compare
A staggered X axis leads to flat-top hexes whereas a staggered Y axis leads to pointy-top hexes.
This setting also applies to maps using Isometric (Staggered) orientation, in which case this distinction does not exist, so I'm not entirely sure whether this is a good idea. Should we have the property only use the additional labels when the map is using Hexagonal orientation?